SPDY - Added unit tests for use after free of SpdySession

SPDY - Added unit tests for use after free of SpdySession
and unit test to test yielding + async during Read.

A test that crashes when scoped_refptr to SpdySession deleted
from DoLoop.

Added the following test per rch to test interactions of
yielding + async during Read.

Do the following MockReads and verify all the data is consumed
and SpdySession has yielded during Read.
  SYNCHRONOUS 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 2K
  ASYNC 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 8K
  SYNCHRONOUS 2K

R=rch@chromium.org
BUG=175574, 166958
TEST=net unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182012

[ramant (doing other things), 2013-02-12 00:47:29]

Hi rch@,
  Added unit tests we had discussed for SpdySession. Could you please take a
look?

[Ryan Hamilton, 2013-02-12 16:33:30]

Your new test looks good to me.  I'm not sure I understand the motivation for
the change to the other test, though.  Can you elaborate?

[ramant (doing other things), 2013-02-12 18:16:40]

On 2013/02/12 16:33:30, Ryan Hamilton wrote:
> Your new test looks good to me.  I'm not sure I understand the motivation for
> the change to the other test, though.  Can you elaborate?

The old test DISABLED_TestYieldingDuringLargeReadData was wrong. That test was
creating a MockRead of more than 8k. 

SpdySession's socket->read was only reading 8k and we hit the following DCHECK
in  DeterministicMockTCPClientSocket::Read

// The buffer should always be big enough to contain all the MockRead data. To
// use small buffers, split the data into multiple MockReads.
DCHECK_LE(read_data_.data_len, buf_len);

We had come up with a new test (reading 26k of data synchronously, followed by
6k of Async read followed by reading of 26k data).

Changed the DISABLED test to test the new one. Should I leave the DISABLED_...
test and add a new test? thanks.

[Ryan Hamilton, 2013-02-12 18:35:39]

One small suggestion.

https://codereview.chromium.org/12207122/diff/7002/net/spdy/spdy_session_spdy...
File net/spdy/spdy_session_spdy2_unittest.cc (right):

https://codereview.chromium.org/12207122/diff/7002/net/spdy/spdy_session_spdy...
net/spdy/spdy_session_spdy2_unittest.cc:1872:
CreateMockRead(*sixk_bytes_data_frame, 6, ASYNC),
Can you make this return 8K?

[ramant (doing other things), 2013-02-12 18:44:43]

Made the change rch. PTAL. thanks.

https://codereview.chromium.org/12207122/diff/7002/net/spdy/spdy_session_spdy...
File net/spdy/spdy_session_spdy2_unittest.cc (right):

https://codereview.chromium.org/12207122/diff/7002/net/spdy/spdy_session_spdy...
net/spdy/spdy_session_spdy2_unittest.cc:1872:
CreateMockRead(*sixk_bytes_data_frame, 6, ASYNC),
On 2013/02/12 18:35:39, Ryan Hamilton wrote:
> Can you make this return 8K?

Done.

[Ryan Hamilton, 2013-02-12 18:45:25]

lgtm

[commit-bot: I haz the power, 2013-02-12 18:47:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtenneti@chromium.org/12207122/8003

[commit-bot: I haz the power, 2013-02-12 21:15:53]

Change committed as 182012