add support for template repeat

lib/templating.dart

Index: lib/templating.dart
diff --git a/lib/templating.dart b/lib/templating.dart
index b8cb7856c23cad7299c3807312fa403d70176a92..65b685fade0354cbc2c24378d42ad37524bd4c90 100644
--- a/lib/templating.dart
+++ b/lib/templating.dart
@@ -456,10 +456,16 @@ class Template extends TemplateItem {
   }
 
   /** Watch [exp] and render a loop while this template is visible. */
-  void loop(Node template, exp, iterSetup, {isTemplateElement: true}) {
-    children.add(
-        isTemplateElement ?  new LoopTemplate(template, exp, iterSetup)
-        : new LoopTemplateInAttribute(template, exp, iterSetup));
+  void loop(Node template, exp, iterSetup) {
+    children.add(new LoopTemplate(template, exp, iterSetup));
+  }
+
+  /**
+   * Watch [exp] and render a loop while this template is visible.
+   * NOTE: this form is deprecated. Please use [loop] instead.
+   */
+  void loopIterateAttr(Node template, exp, iterSetup) {

[Siggi Cherem (dart-lang), 2013/04/05 20:09:24]

should we add @deprecated?

[Jennifer Messerly, 2013/04/05 20:34:36]

:) yeah I had the same thought. My fear was that our compiler would generate
code with warnings, which might trip up editor users and make it harder for our
analyzer test to verify our codegen.

actually, I just removed the deprecation comment for now (here and in analyzer).
I'm not convinced about deprecation--it seems like until we have real <template>
parsing, both forms of template attribute can be useful in some cases

+    children.add(new LoopTemplateInAttribute(template, exp, iterSetup));
   }
 
   /** Bind the lifecycle of the component with this template's lifecycle. */
@@ -601,7 +607,10 @@ class ConditionalTemplate extends PlaceholderTemplate {
 /** Function to set up the contents of a loop template. */
 typedef void LoopIterationSetup(loopVariable, Template template);
 
-/** A template loop of the form `<template iterate="x in list ">`. */
+/**
+ * A template loop of the form `<template iterate="x in list ">` or
+ * `<td template repeat="x in list">`.
+ */
 class LoopTemplate extends PlaceholderTemplate {
   final LoopIterationSetup iterSetup;