add support for template repeat

add support for template repeat

it's identical with template element, but with template attribute it adds additional capabilities and should work more conveniently in cases like <td> and <option>

Committed: https://github.com/dart-lang/web-ui/commit/a6778bb

[Siggi Cherem (dart-lang), 2013-04-05 20:09:23]

nice! just minor comments below, but otherwise lgtm!

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/src/analyzer.dart
File lib/src/analyzer.dart (right):

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/src/analyzer.dart#...
lib/src/analyzer.dart:373: result.removeAttributes.add('template');
consider moving this inside the if (given that it is also done by
_createTemplateAttribuetPlaceholder)?

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/src/html_cleaner.dart
File lib/src/html_cleaner.dart (right):

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/src/html_cleaner.d...
lib/src/html_cleaner.dart:41: (info.hasCondition || info.isRepeat)) {
why not info.hasLoop?

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/src/info.dart
File lib/src/info.dart (right):

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/src/info.dart#newc...
lib/src/info.dart:550: * True if this is a repeat. Otherwise, it is an iterate.
maybe clarify that this is only if 'hasLoop' is true, otherwise 'isRepeat' is
irrelevant

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/templating.dart
File lib/templating.dart (right):

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/templating.dart#ne...
lib/templating.dart:467: void loopIterateAttr(Node template, exp, iterSetup) {
should we add @deprecated?

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/web_ui.dart
File lib/web_ui.dart (right):

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/web_ui.dart#newcode48
lib/web_ui.dart:48: _elements[name] = new _CustomElementInfo(element, template);
should we warn when there are conflicts on the name?

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/web_ui.dart#newcode74
lib/web_ui.dart:74: 
looks like these changes below with a different change? (for the _root fix?)

[Jennifer Messerly, 2013-04-05 20:34:36]

PTAL!

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/src/analyzer.dart
File lib/src/analyzer.dart (right):

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/src/analyzer.dart#...
lib/src/analyzer.dart:373: result.removeAttributes.add('template');
On 2013/04/05 20:09:24, Siggi Cherem (dart-lang) wrote:
> consider moving this inside the if (given that it is also done by
> _createTemplateAttribuetPlaceholder)?

oops. good catch!

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/src/html_cleaner.dart
File lib/src/html_cleaner.dart (right):

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/src/html_cleaner.d...
lib/src/html_cleaner.dart:41: (info.hasCondition || info.isRepeat)) {
On 2013/04/05 20:09:24, Siggi Cherem (dart-lang) wrote:
> why not info.hasLoop?

wow, the comment is way out of date. I've fixed it. You can tell me if it
answers the question--I hope so :)

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/src/info.dart
File lib/src/info.dart (right):

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/src/info.dart#newc...
lib/src/info.dart:550: * True if this is a repeat. Otherwise, it is an iterate.
On 2013/04/05 20:09:24, Siggi Cherem (dart-lang) wrote:
> maybe clarify that this is only if 'hasLoop' is true, otherwise 'isRepeat' is
> irrelevant

thanks, clarified.

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/templating.dart
File lib/templating.dart (right):

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/templating.dart#ne...
lib/templating.dart:467: void loopIterateAttr(Node template, exp, iterSetup) {
On 2013/04/05 20:09:24, Siggi Cherem (dart-lang) wrote:
> should we add @deprecated?

:) yeah I had the same thought. My fear was that our compiler would generate
code with warnings, which might trip up editor users and make it harder for our
analyzer test to verify our codegen.

actually, I just removed the deprecation comment for now (here and in analyzer).
I'm not convinced about deprecation--it seems like until we have real <template>
parsing, both forms of template attribute can be useful in some cases

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/web_ui.dart
File lib/web_ui.dart (right):

https://chromiumcodereview.appspot.com/13592003/diff/1/lib/web_ui.dart#newcode74
lib/web_ui.dart:74: 
On 2013/04/05 20:09:24, Siggi Cherem (dart-lang) wrote:
> looks like these changes below with a different change? (for the _root fix?)

Yes! good catch. :D

[Siggi Cherem (dart-lang), 2013-04-05 20:37:32]

lgtm!

Thanks!

[Jennifer Messerly, 2013-04-05 21:00:19]

Committed patchset #2 manually as ra6778bb (presubmit successful).