add support for template repeat

lib/templating.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** Common utility functions used by code generated by the dwc compiler. */
 library templating;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:html';
@@ skipping 438 matching lines @@
   void oneWayBind(exp, setter, isFinal, [isUrl = false]) {
     children.add(new DomPropertyBinding(exp, setter, isUrl, isFinal));
   }
 
   /** Watch [exp] and render a conditional while this template is visible. */
   void conditional(Node template, exp, bodySetup) {
     children.add(new ConditionalTemplate(template, exp, bodySetup));
   }
 
   /** Watch [exp] and render a loop while this template is visible. */
-  void loop(Node template, exp, iterSetup, {isTemplateElement: true}) {
-    children.add(
-        isTemplateElement ?  new LoopTemplate(template, exp, iterSetup)
-        : new LoopTemplateInAttribute(template, exp, iterSetup));
+  void loop(Node template, exp, iterSetup) {
+    children.add(new LoopTemplate(template, exp, iterSetup));
+  }
+
+  /**
+   * Watch [exp] and render a loop while this template is visible.
+   * NOTE: this form is deprecated. Please use [loop] instead.
+   */
+  void loopIterateAttr(Node template, exp, iterSetup) {

[Siggi Cherem (dart-lang), 2013/04/05 20:09:24]

should we add @deprecated?

[Jennifer Messerly, 2013/04/05 20:34:36]

:) yeah I had the same thought. My fear was that our compiler would generate
code with warnings, which might trip up editor users and make it harder for our
analyzer test to verify our codegen.

actually, I just removed the deprecation comment for now (here and in analyzer).
I'm not convinced about deprecation--it seems like until we have real <template>
parsing, both forms of template attribute can be useful in some cases

+    children.add(new LoopTemplateInAttribute(template, exp, iterSetup));
   }
 
   /** Bind the lifecycle of the component with this template's lifecycle. */
   void component(WebComponent component) {
     children.add(new ComponentItem(component));
   }
 
   // TODO(sigmund): consider changing emitter to accept compact arguments here
   // for instance:
   //   __t.add(string) => add(new Text(string))
@@ skipping 121 matching lines @@
   void remove() {
     super.remove();
     stopper();
     stopper = null;
   }
 }
 
 /** Function to set up the contents of a loop template. */
 typedef void LoopIterationSetup(loopVariable, Template template);
 
-/** A template loop of the form `<template iterate="x in list ">`. */
+/**
+ * A template loop of the form `<template iterate="x in list ">` or
+ * `<td template repeat="x in list">`.
+ */
 class LoopTemplate extends PlaceholderTemplate {
   final LoopIterationSetup iterSetup;
 
   LoopTemplate(Node reference, exp, this.iterSetup) : super(reference, exp);
 
   void insert() {
     stopper = watchAndInvoke(exp, (e) {
       super.remove();
       for (var x in e.newValue) {
         iterSetup(x, this);
@@ skipping 41 matching lines @@
     node.nodes.clear();
     nodes.clear();
   }
 
   void remove() {
     _removeInternal();
     stopper();
     stopper = null;
   }
 }