Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1358063003: Add Kind/StringID/IntID back to Key. (Closed)

Created:
5 years, 3 months ago by iannucci
Modified:
5 years, 3 months ago
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@add_allocate_ids
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -24 lines) Patch
M filter/dscache/dscache_test.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/memory/datastore_data.go View 2 chunks +2 lines, -2 lines 0 comments Download
M impl/memory/datastore_index.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/prod/raw_datastore.go View 1 chunk +1 line, -1 line 0 comments Download
M service/datastore/datastore_test.go View 12 chunks +14 lines, -14 lines 0 comments Download
M service/datastore/key.go View 4 chunks +13 lines, -4 lines 2 comments Download
M service/datastore/multiarg.go View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (1 generated)
iannucci
5 years, 3 months ago (2015-09-22 17:51:57 UTC) #1
dnj
lgtm w/ nit https://codereview.chromium.org/1358063003/diff/1/service/datastore/key.go File service/datastore/key.go (right): https://codereview.chromium.org/1358063003/diff/1/service/datastore/key.go#newcode192 service/datastore/key.go:192: func (k *Key) Kind() string { ...
5 years, 3 months ago (2015-09-22 17:56:19 UTC) #2
Vadim Sh.
lgtm though I'd prefer "LastPair()" instead of "LastTok()". But you use Tok to identify (kind, ...
5 years, 3 months ago (2015-09-22 17:57:14 UTC) #3
iannucci
On 2015/09/22 at 17:57:14, vadimsh wrote: > lgtm > > though I'd prefer "LastPair()" instead ...
5 years, 3 months ago (2015-09-22 18:12:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358063003/1
5 years, 3 months ago (2015-09-22 18:13:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/gae/commit/84d674199367bc12a173d8b9a3483345dc942fdc
5 years, 3 months ago (2015-09-22 18:14:53 UTC) #7
iannucci
5 years, 3 months ago (2015-09-23 23:51:48 UTC) #8
Message was sent while issue was closed.
oh, forgot to publish >_<

https://codereview.chromium.org/1358063003/diff/1/service/datastore/key.go
File service/datastore/key.go (right):

https://codereview.chromium.org/1358063003/diff/1/service/datastore/key.go#ne...
service/datastore/key.go:192: func (k *Key) Kind() string { return
k.toks[len(k.toks)-1].Kind }
On 2015/09/22 at 17:56:19, dnj wrote:
> nit: Use "LastTok" here (and in StringID and IntID).

nah, it creates an extra copy I don't want.

Powered by Google App Engine
This is Rietveld 408576698