Add missing AllocateIDs API.

Add missing AllocateIDs API.

No idea why I missed it. Tweaked a bit to get rid of some redunant info.

R=dnj@chromium.org, estaab@chromium.org, maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org
BUG=

Committed: https://github.com/luci/gae/commit/c8379fc606626b53758fbfbcf361f02a78ebc8b0

[dnj (Google), 2015-09-22 06:36:05]

dnj@google.com changed reviewers:
+ dnj@google.com

[dnj (Google), 2015-09-22 06:36:06]

lgtm w/ a few nits

https://codereview.chromium.org/1357343002/diff/1/impl/memory/datastore_data.go
File impl/memory/datastore_data.go (right):

https://codereview.chromium.org/1357343002/diff/1/impl/memory/datastore_data....
impl/memory/datastore_data.go:112: func incrementLocked(ents *memCollection, key
[]byte, amt int) int64 {
nit: WDYT about panic if amt <= 0. I know checkfilter catches it, but it would
still wreak havoc here if it ever happened (unfiltered raw interface, etc.).

https://codereview.chromium.org/1357343002/diff/1/impl/prod/raw_datastore.go
File impl/prod/raw_datastore.go (right):

https://codereview.chromium.org/1357343002/diff/1/impl/prod/raw_datastore.go#...
impl/prod/raw_datastore.go:55: start, _, err = datastore.AllocateIDs(d,
incomplete.Last().Kind, par, n)
(nit/thought): incomplete.Last().Kind() should probably be a top-level Key
function, like incomplete.Kind()

[iannucci, 2015-09-22 16:41:04]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2015-09-22 16:41:05]

https://chromiumcodereview.appspot.com/1357343002/diff/1/impl/memory/datastor...
File impl/memory/datastore_data.go (right):

https://chromiumcodereview.appspot.com/1357343002/diff/1/impl/memory/datastor...
impl/memory/datastore_data.go:112: func incrementLocked(ents *memCollection, key
[]byte, amt int) int64 {
On 2015/09/22 at 06:36:06, dnj (Google) wrote:
> nit: WDYT about panic if amt <= 0. I know checkfilter catches it, but it would
still wreak havoc here if it ever happened (unfiltered raw interface, etc.).

good idea. done.

https://chromiumcodereview.appspot.com/1357343002/diff/1/impl/prod/raw_datast...
File impl/prod/raw_datastore.go (right):

https://chromiumcodereview.appspot.com/1357343002/diff/1/impl/prod/raw_datast...
impl/prod/raw_datastore.go:55: start, _, err = datastore.AllocateIDs(d,
incomplete.Last().Kind, par, n)
On 2015/09/22 at 06:36:06, dnj (Google) wrote:
> (nit/thought): incomplete.Last().Kind() should probably be a top-level Key
function, like incomplete.Kind()

Yeah... at the time I thought it was a good idea... I think I'll file a CL to do
this and rename Last() to LastTok().

[iannucci, 2015-09-22 16:41:05]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@google.com
Link to the patchset: https://chromiumcodereview.appspot.com/1357343002/#ps20001
(title: "add panic")

[commit-bot: I haz the power, 2015-09-22 16:41:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1357343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1357343002/20001

[commit-bot: I haz the power, 2015-09-22 16:43:49]

Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/c8379fc606626b53758fbfbcf361f02a78ebc8b0