Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1359813004: Use new StringID function. (Closed)

Created:
5 years, 3 months ago by iannucci
Modified:
5 years, 3 months ago
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, todd, andrew.wang, M-A Ruel, tandrii(chromium)
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M appengine/cmd/cron/engine/engine.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (3 generated)
iannucci
5 years, 3 months ago (2015-09-22 17:05:01 UTC) #1
Vadim Sh.
lgtm though you'll probably need a roll of luci/gae first
5 years, 3 months ago (2015-09-22 17:07:38 UTC) #2
iannucci
On 2015/09/22 at 17:07:38, vadimsh wrote: > lgtm > > though you'll probably need a ...
5 years, 3 months ago (2015-09-22 17:51:18 UTC) #3
iannucci
On 2015/09/22 at 17:51:18, iannucci wrote: > On 2015/09/22 at 17:07:38, vadimsh wrote: > > ...
5 years, 3 months ago (2015-09-22 17:52:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359813004/1
5 years, 3 months ago (2015-09-22 18:15:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Presubmit/builds/9)
5 years, 3 months ago (2015-09-22 18:16:54 UTC) #8
Vadim Sh.
Told ya.
5 years, 3 months ago (2015-09-22 18:18:10 UTC) #9
iannucci
On 2015/09/22 at 18:18:10, vadimsh wrote: > Told ya. ..... the other one landed already
5 years, 3 months ago (2015-09-22 18:35:26 UTC) #10
iannucci
On 2015/09/22 at 18:35:26, iannucci wrote: > On 2015/09/22 at 18:18:10, vadimsh wrote: > > ...
5 years, 3 months ago (2015-09-22 18:35:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359813004/1
5 years, 3 months ago (2015-09-22 19:29:01 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 19:32:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/b25e3fe8196c6c7a1ea732daa9f1a78730a09588

Powered by Google App Engine
This is Rietveld 408576698