Issue 13529017: Remove unnecessary explicity prototype check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13529017: Remove unnecessary explicity prototype check. (Closed)

Created:
7 years, 8 months ago by Toon Verwaest

Modified:
7 years, 8 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove unnecessary explicity prototype check. The prototype is implicitly checked through a map check of the holder. This is either checked in CheckPrototypes, or as part of the IC. Committed: https://code.google.com/p/v8/source/detail?r=14155

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -32 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	2 chunks	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

7 years, 8 months ago (2013-04-05 15:17:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14155 (presubmit successful).

Expand Messages | Collapse Messages