Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 13529017: Remove unnecessary explicity prototype check. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1207 matching lines...) Expand 10 before | Expand all | Expand 10 after
1218 1218
1219 1219
1220 void BaseLoadStubCompiler::NonexistentHandlerFrontend( 1220 void BaseLoadStubCompiler::NonexistentHandlerFrontend(
1221 Handle<JSObject> object, 1221 Handle<JSObject> object,
1222 Handle<JSObject> last, 1222 Handle<JSObject> last,
1223 Handle<Name> name, 1223 Handle<Name> name,
1224 Label* success, 1224 Label* success,
1225 Handle<GlobalObject> global) { 1225 Handle<GlobalObject> global) {
1226 Label miss; 1226 Label miss;
1227 1227
1228 Register reg = HandlerFrontendHeader(object, receiver(), last, name, &miss); 1228 HandlerFrontendHeader(object, receiver(), last, name, &miss);
1229 1229
1230 // If the last object in the prototype chain is a global object, 1230 // If the last object in the prototype chain is a global object,
1231 // check that the global property cell is empty. 1231 // check that the global property cell is empty.
1232 if (!global.is_null()) { 1232 if (!global.is_null()) {
1233 GenerateCheckPropertyCell(masm(), global, name, scratch2(), &miss); 1233 GenerateCheckPropertyCell(masm(), global, name, scratch2(), &miss);
1234 } 1234 }
1235 1235
1236 if (!last->HasFastProperties()) {
1237 __ ldr(scratch2(), FieldMemOperand(reg, HeapObject::kMapOffset));
1238 __ ldr(scratch2(), FieldMemOperand(scratch2(), Map::kPrototypeOffset));
1239 __ cmp(scratch2(), Operand(isolate()->factory()->null_value()));
1240 __ b(ne, &miss);
1241 }
1242
1243 HandlerFrontendFooter(success, &miss); 1236 HandlerFrontendFooter(success, &miss);
1244 } 1237 }
1245 1238
1246 1239
1247 void BaseLoadStubCompiler::GenerateLoadField(Register reg, 1240 void BaseLoadStubCompiler::GenerateLoadField(Register reg,
1248 Handle<JSObject> holder, 1241 Handle<JSObject> holder,
1249 PropertyIndex index) { 1242 PropertyIndex index) {
1250 GenerateFastPropertyLoad(masm(), r0, reg, holder, index); 1243 GenerateFastPropertyLoad(masm(), r0, reg, holder, index);
1251 __ Ret(); 1244 __ Ret();
1252 } 1245 }
(...skipping 2602 matching lines...) Expand 10 before | Expand all | Expand 10 after
3855 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3848 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3856 } 3849 }
3857 } 3850 }
3858 3851
3859 3852
3860 #undef __ 3853 #undef __
3861 3854
3862 } } // namespace v8::internal 3855 } } // namespace v8::internal
3863 3856
3864 #endif // V8_TARGET_ARCH_ARM 3857 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698