Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: src/x64/stub-cache-x64.cc

Issue 13529017: Remove unnecessary explicity prototype check. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/stub-cache-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1059 matching lines...) Expand 10 before | Expand all | Expand 10 after
1070 1070
1071 1071
1072 void BaseLoadStubCompiler::NonexistentHandlerFrontend( 1072 void BaseLoadStubCompiler::NonexistentHandlerFrontend(
1073 Handle<JSObject> object, 1073 Handle<JSObject> object,
1074 Handle<JSObject> last, 1074 Handle<JSObject> last,
1075 Handle<Name> name, 1075 Handle<Name> name,
1076 Label* success, 1076 Label* success,
1077 Handle<GlobalObject> global) { 1077 Handle<GlobalObject> global) {
1078 Label miss; 1078 Label miss;
1079 1079
1080 Register reg = HandlerFrontendHeader(object, receiver(), last, name, &miss); 1080 HandlerFrontendHeader(object, receiver(), last, name, &miss);
1081 1081
1082 // If the last object in the prototype chain is a global object, 1082 // If the last object in the prototype chain is a global object,
1083 // check that the global property cell is empty. 1083 // check that the global property cell is empty.
1084 if (!global.is_null()) { 1084 if (!global.is_null()) {
1085 GenerateCheckPropertyCell(masm(), global, name, scratch2(), &miss); 1085 GenerateCheckPropertyCell(masm(), global, name, scratch2(), &miss);
1086 } 1086 }
1087 1087
1088 if (!last->HasFastProperties()) {
1089 __ movq(scratch2(), FieldOperand(reg, HeapObject::kMapOffset));
1090 __ movq(scratch2(), FieldOperand(scratch2(), Map::kPrototypeOffset));
1091 __ Cmp(scratch2(), isolate()->factory()->null_value());
1092 __ j(not_equal, &miss);
1093 }
1094
1095 HandlerFrontendFooter(success, &miss); 1088 HandlerFrontendFooter(success, &miss);
1096 } 1089 }
1097 1090
1098 1091
1099 void BaseLoadStubCompiler::GenerateLoadField(Register reg, 1092 void BaseLoadStubCompiler::GenerateLoadField(Register reg,
1100 Handle<JSObject> holder, 1093 Handle<JSObject> holder,
1101 PropertyIndex index) { 1094 PropertyIndex index) {
1102 // Get the value from the properties. 1095 // Get the value from the properties.
1103 GenerateFastPropertyLoad(masm(), rax, reg, holder, index); 1096 GenerateFastPropertyLoad(masm(), rax, reg, holder, index);
1104 __ ret(0); 1097 __ ret(0);
(...skipping 2309 matching lines...) Expand 10 before | Expand all | Expand 10 after
3414 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow); 3407 TailCallBuiltin(masm, Builtins::kKeyedStoreIC_Slow);
3415 } 3408 }
3416 } 3409 }
3417 3410
3418 3411
3419 #undef __ 3412 #undef __
3420 3413
3421 } } // namespace v8::internal 3414 } } // namespace v8::internal
3422 3415
3423 #endif // V8_TARGET_ARCH_X64 3416 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/stub-cache-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698