Support per property CSS Animation stacks

Support per property CSS Animation stacks

This change enables individual CSS properties to track multiple animations
occuring on them at the same time and to composite the animations together
as defined by the Web Animations spec:
http://w3c.github.io/web-animations/#combining-effects

This behaviour guarded by the StackedCSSPropertyAnimations flag and is
only enabled for experimental Blink by default.

BUG=437696
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201864

[alancutter (OOO until 2018), 2015-09-04 02:56:05]

alancutter@chromium.org changed reviewers:
+ dstockwell@chromium.org, shans@chromium.org

[dstockwell, 2015-09-07 03:11:37]

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/A...
File Source/core/animation/AnimationStack.cpp (right):

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/A...
Source/core/animation/AnimationStack.cpp:46: void
copyToActiveInterpolationMap(const Vector<RefPtr<Interpolation>>& source,
ActiveInterpolationsMap& target)
copyToActiveInterpolation*s*Map?

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/A...
Source/core/animation/AnimationStack.cpp:52:
target.set(interpolation->property(),
ActiveInterpolations(1)).storedValue->value.at(0) = interpolation.get();
is there a way to avoid the second hash here?

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/A...
Source/core/animation/AnimationStack.cpp:55: &&
toInvalidatableStyleInterpolation(*interpolation).dependsOnUnderlyingValue()) {
Why is dependonunderlying part of invalidatablestyleinterpolation -- I assume
this will apply to other interpolations too?

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/I...
File Source/core/animation/InvalidatableStyleInterpolation.cpp (right):

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/I...
Source/core/animation/InvalidatableStyleInterpolation.cpp:129:
OwnPtr<InterpolationValue> underlyingValueOwner = nullptr;
Let's see if we can encapsulate this ownptr/rawptr split into a helper.

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/I...
Source/core/animation/InvalidatableStyleInterpolation.cpp:136:
firstInterpolation.ensureValidInterpolation(state, nullptr);
Should ensureValidInterpolation just return the m_cachedValue? It seems we
always use it that way.

[alancutter (OOO until 2018), 2015-09-07 03:36:46]

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/A...
File Source/core/animation/AnimationStack.cpp (right):

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/A...
Source/core/animation/AnimationStack.cpp:46: void
copyToActiveInterpolationMap(const Vector<RefPtr<Interpolation>>& source,
ActiveInterpolationsMap& target)
On 2015/09/07 at 03:11:36, dstockwell wrote:
> copyToActiveInterpolation*s*Map?

Done.

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/A...
Source/core/animation/AnimationStack.cpp:52:
target.set(interpolation->property(),
ActiveInterpolations(1)).storedValue->value.at(0) = interpolation.get();
On 2015/09/07 at 03:11:36, dstockwell wrote:
> is there a way to avoid the second hash here?

Done.

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/A...
Source/core/animation/AnimationStack.cpp:55: &&
toInvalidatableStyleInterpolation(*interpolation).dependsOnUnderlyingValue()) {
On 2015/09/07 at 03:11:36, dstockwell wrote:
> Why is dependonunderlying part of invalidatablestyleinterpolation -- I assume
this will apply to other interpolations too?

Correct, InvalidatableStyleInterpolation will eventually be merged upstream into
Interpolation once the old code has been replaced completely.

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/I...
File Source/core/animation/InvalidatableStyleInterpolation.cpp (right):

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/I...
Source/core/animation/InvalidatableStyleInterpolation.cpp:129:
OwnPtr<InterpolationValue> underlyingValueOwner = nullptr;
On 2015/09/07 at 03:11:37, dstockwell wrote:
> Let's see if we can encapsulate this ownptr/rawptr split into a helper.

Done.

https://codereview.chromium.org/1329843002/diff/60001/Source/core/animation/I...
Source/core/animation/InvalidatableStyleInterpolation.cpp:136:
firstInterpolation.ensureValidInterpolation(state, nullptr);
On 2015/09/07 at 03:11:37, dstockwell wrote:
> Should ensureValidInterpolation just return the m_cachedValue? It seems we
always use it that way.

Good idea, done.

[dstockwell, 2015-09-07 03:46:23]

lgtm

https://codereview.chromium.org/1329843002/diff/120001/Source/core/animation/...
File Source/core/animation/InvalidatableStyleInterpolation.cpp (right):

https://codereview.chromium.org/1329843002/diff/120001/Source/core/animation/...
Source/core/animation/InvalidatableStyleInterpolation.cpp:138: m_pointer =
const_cast<InterpolationValue*>(interpolationValue);
comment why this is safe

https://codereview.chromium.org/1329843002/diff/120001/Source/core/animation/...
Source/core/animation/InvalidatableStyleInterpolation.cpp:179: if (firstValue) {
merge with previous line

[alancutter (OOO until 2018), 2015-09-07 04:34:11]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2015-09-07 04:34:13]

https://codereview.chromium.org/1329843002/diff/120001/Source/core/animation/...
File Source/core/animation/InvalidatableStyleInterpolation.cpp (right):

https://codereview.chromium.org/1329843002/diff/120001/Source/core/animation/...
Source/core/animation/InvalidatableStyleInterpolation.cpp:138: m_pointer =
const_cast<InterpolationValue*>(interpolationValue);
On 2015/09/07 at 03:46:23, dstockwell wrote:
> comment why this is safe

Done.

https://codereview.chromium.org/1329843002/diff/120001/Source/core/animation/...
Source/core/animation/InvalidatableStyleInterpolation.cpp:179: if (firstValue) {
On 2015/09/07 at 03:46:23, dstockwell wrote:
> merge with previous line

It would not be equivalent due to the return statement.

[alancutter (OOO until 2018), 2015-09-07 04:34:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1329843002/#ps90015
(title: "Comment")

[commit-bot: I haz the power, 2015-09-07 04:34:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329843002/90015
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329843002/90015

[commit-bot: I haz the power, 2015-09-07 04:42:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-07 04:42:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[alancutter (OOO until 2018), 2015-09-07 05:14:55]

alancutter@chromium.org changed reviewers:
+ noel@chromium.org

[alancutter (OOO until 2018), 2015-09-07 05:14:56]

+noel for Source/platform/RuntimeEnabledFeatures.in review.

[Noel Gordon, 2015-09-07 06:43:00]

On 2015/09/07 05:14:56, alancutter wrote:
> +noel for Source/platform/RuntimeEnabledFeatures.in review.

Source/platform/RuntimeEnabledFeatures.in seems fine.  LGTM.

[alancutter (OOO until 2018), 2015-09-07 06:45:03]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2015-09-07 06:45:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org
Link to the patchset: https://codereview.chromium.org/1329843002/#ps210001
(title: "Lint")

[commit-bot: I haz the power, 2015-09-07 06:45:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1329843002/210001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1329843002/210001

[commit-bot: I haz the power, 2015-09-07 08:05:32]

Committed patchset #12 (id:210001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201864