Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1326443003: Web Animations: Enable additive animations in experimental (Closed)

Created:
5 years, 3 months ago by alancutter (OOO until 2018)
Modified:
5 years, 3 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Inactive, Eric Willigers, rjwright, shans, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Web Animations: Enable additive animations in experimental This patch enables additive keyframes in Web Animations element.animate(). "composite: 'add'" keyframe properties and neutral keyframes are now enabled in experimental only. This patch removes tests that assert we throw errors when additive or neutral keyframes are used in element.animate(). The following existing tests ensure that stable behaviour has not changed: virtual/stable/web-animations-api/additive-animations-unsupported.html virtual/stable/web-animations-api/partial-keyframes-unsupported.html BUG=437696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201885

Patch Set 1 #

Patch Set 2 : Update tests #

Patch Set 3 : Rename #

Patch Set 4 : Update missed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -367 lines) Patch
A LayoutTests/animations/composition/left-composition.html View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/resources/interpolation-test.js View 1 2 8 chunks +140 lines, -64 lines 0 comments Download
M LayoutTests/fast/inline/inline-marquee-crash-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/web-animations-api/partial-keyframes.html View 1 1 chunk +0 lines, -131 lines 0 comments Download
D LayoutTests/web-animations-api/w3c/add-keyframes.html View 1 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/web-animations-api/w3c/insufficient-keyframes.html View 1 1 chunk +0 lines, -39 lines 0 comments Download
M Source/core/animation/EffectInput.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/EffectInput.cpp View 1 2 chunks +16 lines, -8 lines 0 comments Download
M Source/core/animation/ElementAnimation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/animation/ElementAnimation.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/KeyframeEffectTest.cpp View 1 2 3 1 chunk +0 lines, -83 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1329843002 Patch 210001

Messages

Total messages: 14 (6 generated)
alancutter (OOO until 2018)
5 years, 3 months ago (2015-09-07 02:37:18 UTC) #2
dstockwell
lgtm
5 years, 3 months ago (2015-09-07 06:29:34 UTC) #3
alancutter (OOO until 2018)
+noel for Source/platform/RuntimeEnabledFeatures.in review.
5 years, 3 months ago (2015-09-07 06:35:07 UTC) #5
Noel Gordon
On 2015/09/07 06:35:07, alancutter wrote: > +noel for Source/platform/RuntimeEnabledFeatures.in review. LGTM.
5 years, 3 months ago (2015-09-07 06:49:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326443003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326443003/40001
5 years, 3 months ago (2015-09-07 23:52:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/104027)
5 years, 3 months ago (2015-09-08 00:50:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326443003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326443003/60001
5 years, 3 months ago (2015-09-08 01:11:27 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 02:32:04 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201885

Powered by Google App Engine
This is Rietveld 408576698