Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1328773002: Make classes and structures in web fast-allocated. (Closed)

Created:
5 years, 3 months ago by tasak
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, tzik, dshwang, dcheng, apavlov+blink_chromium.org, rwlbuis, caseq+blink_chromium.org, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, yurys+blink_chromium.org, Justin Novosad, danakj, Rik, devtools-reviews_chromium.org, philipj_slow, jbroman, lushnikov+blink_chromium.org, feature-media-reviews_chromium.org, krit, eric.carlson_apple.com, sergeyv+blink_chromium.org, nhiroki, Yoav Weiss, gavinp+prerender_chromium.org, mlamouri+watch-blink_chromium.org, blink-layers+watch_chromium.org, pfeldman+blink_chromium.org, f(malita), Stephen Chennney, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make classes and structures in web fast-allocated. - Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -4 lines) Patch
M Source/platform/graphics/GraphicsLayerFactory.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/AssociatedURLLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ColorChooserUIController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ContextMenuClientImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/DatabaseClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/DevToolsEmulator.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/DragClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/EditorClientImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/FullscreenController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/LinkHighlightImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/MIDIClientProxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/MediaKeysClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/NotificationPermissionClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/OpenedFrameTracker.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/PageOverlay.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/PageWidgetDelegate.h View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/web/PrerendererClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/RemoteBridgeFrameOwner.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/SpeechRecognitionClientProxy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/SpellCheckerClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/StorageClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/StorageQuotaClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/TextFinder.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/UserMediaClientImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/ValidationMessageClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebDevToolsFrontendImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebEntities.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/WebFileChooserCompletionImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebFontImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebGraphicsContextImpl.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/web/WebInputEventConversion.h View 7 chunks +12 lines, -0 lines 0 comments Download
M Source/web/WebPluginLoadObserver.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSocketImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/WebTextCheckingCompletionImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WorkerContentSettingsClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WorkerGlobalScopeProxyProviderImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/painting/PaintAggregator.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/web/tests/FakeWebPlugin.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 6 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tasak
Would you review this CL?
5 years, 3 months ago (2015-09-04 02:43:31 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-04 03:34:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328773002/1
5 years, 3 months ago (2015-09-04 04:17:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201771
5 years, 3 months ago (2015-09-04 04:22:59 UTC) #6
tasak
5 years, 3 months ago (2015-09-04 10:15:08 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1326693003/ by tasak@google.com.

The reason for reverting is: Revert to see whether
SitePerProcessBrowserTest.SurfaceHitTestTest flakiness is caused by this commit
or not.
.

Powered by Google App Engine
This is Rietveld 408576698