Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: Source/core/animation/KeyframeEffectTest.cpp

Issue 1326443003: Web Animations: Enable additive animations in experimental (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update missed tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/ElementAnimation.idl ('k') | Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/KeyframeEffectTest.cpp
diff --git a/Source/core/animation/KeyframeEffectTest.cpp b/Source/core/animation/KeyframeEffectTest.cpp
index 52f5539f4758aa5c5ebbd28747cf548b8e27b161..ae1413e4a4ed0b74c7e5cace3dd91a93dd961b68 100644
--- a/Source/core/animation/KeyframeEffectTest.cpp
+++ b/Source/core/animation/KeyframeEffectTest.cpp
@@ -135,89 +135,6 @@ TEST_F(AnimationKeyframeEffectV8Test, NegativeDurationIsAuto)
EXPECT_TRUE(std::isnan(animation->specifiedTiming().iterationDuration));
}
-TEST_F(AnimationKeyframeEffectV8Test, MismatchedKeyframePropertyRaisesException)
-{
- Vector<Dictionary> jsKeyframes;
- v8::Local<v8::Object> keyframe1 = v8::Object::New(m_isolate);
- v8::Local<v8::Object> keyframe2 = v8::Object::New(m_isolate);
-
- setV8ObjectPropertyAsString(m_isolate, keyframe1, "width", "100px");
- setV8ObjectPropertyAsString(m_isolate, keyframe1, "offset", "0");
-
- // Height property appears only in keyframe2
- setV8ObjectPropertyAsString(m_isolate, keyframe2, "height", "100px");
- setV8ObjectPropertyAsString(m_isolate, keyframe2, "width", "0px");
- setV8ObjectPropertyAsString(m_isolate, keyframe2, "offset", "1");
-
- jsKeyframes.append(Dictionary(keyframe1, m_isolate, exceptionState));
- jsKeyframes.append(Dictionary(keyframe2, m_isolate, exceptionState));
-
- createAnimation(element.get(), jsKeyframes, 0, exceptionState);
-
- EXPECT_TRUE(exceptionState.hadException());
- EXPECT_EQ(NotSupportedError, exceptionState.code());
-}
-
-TEST_F(AnimationKeyframeEffectV8Test, MissingOffsetZeroRaisesException)
-{
- Vector<Dictionary> jsKeyframes;
- v8::Local<v8::Object> keyframe1 = v8::Object::New(m_isolate);
- v8::Local<v8::Object> keyframe2 = v8::Object::New(m_isolate);
-
- setV8ObjectPropertyAsString(m_isolate, keyframe1, "width", "100px");
- setV8ObjectPropertyAsString(m_isolate, keyframe1, "offset", "0.1");
- setV8ObjectPropertyAsString(m_isolate, keyframe2, "width", "0px");
- setV8ObjectPropertyAsString(m_isolate, keyframe2, "offset", "1");
-
- jsKeyframes.append(Dictionary(keyframe1, m_isolate, exceptionState));
- jsKeyframes.append(Dictionary(keyframe2, m_isolate, exceptionState));
-
- createAnimation(element.get(), jsKeyframes, 0, exceptionState);
-
- EXPECT_TRUE(exceptionState.hadException());
- EXPECT_EQ(NotSupportedError, exceptionState.code());
-}
-
-TEST_F(AnimationKeyframeEffectV8Test, MissingOffsetOneRaisesException)
-{
- Vector<Dictionary> jsKeyframes;
- v8::Local<v8::Object> keyframe1 = v8::Object::New(m_isolate);
- v8::Local<v8::Object> keyframe2 = v8::Object::New(m_isolate);
-
- setV8ObjectPropertyAsString(m_isolate, keyframe1, "width", "100px");
- setV8ObjectPropertyAsString(m_isolate, keyframe1, "offset", "0");
- setV8ObjectPropertyAsString(m_isolate, keyframe2, "width", "0px");
- setV8ObjectPropertyAsString(m_isolate, keyframe2, "offset", "0.1");
-
- jsKeyframes.append(Dictionary(keyframe1, m_isolate, exceptionState));
- jsKeyframes.append(Dictionary(keyframe2, m_isolate, exceptionState));
-
- createAnimation(element.get(), jsKeyframes, 0, exceptionState);
-
- EXPECT_TRUE(exceptionState.hadException());
- EXPECT_EQ(NotSupportedError, exceptionState.code());
-}
-
-TEST_F(AnimationKeyframeEffectV8Test, MissingOffsetZeroAndOneRaisesException)
-{
- Vector<Dictionary> jsKeyframes;
- v8::Local<v8::Object> keyframe1 = v8::Object::New(m_isolate);
- v8::Local<v8::Object> keyframe2 = v8::Object::New(m_isolate);
-
- setV8ObjectPropertyAsString(m_isolate, keyframe1, "width", "100px");
- setV8ObjectPropertyAsString(m_isolate, keyframe1, "offset", "0.1");
- setV8ObjectPropertyAsString(m_isolate, keyframe2, "width", "0px");
- setV8ObjectPropertyAsString(m_isolate, keyframe2, "offset", "0.2");
-
- jsKeyframes.append(Dictionary(keyframe1, m_isolate, exceptionState));
- jsKeyframes.append(Dictionary(keyframe2, m_isolate, exceptionState));
-
- createAnimation(element.get(), jsKeyframes, 0, exceptionState);
-
- EXPECT_TRUE(exceptionState.hadException());
- EXPECT_EQ(NotSupportedError, exceptionState.code());
-}
-
TEST_F(AnimationKeyframeEffectV8Test, SpecifiedGetters)
{
Vector<Dictionary, 0> jsKeyframes;
« no previous file with comments | « Source/core/animation/ElementAnimation.idl ('k') | Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698