Requery the autofill server when forms and input fields are dynamically added.

components/autofill/renderer/autofill_agent.h

Index: components/autofill/renderer/autofill_agent.h
diff --git a/components/autofill/renderer/autofill_agent.h b/components/autofill/renderer/autofill_agent.h
index 12dd1b560d006d40fc6619843a8b796092f63a01..4fd7a8c48f0e4b49862630d7f54d69e85753af31 100644
--- a/components/autofill/renderer/autofill_agent.h
+++ b/components/autofill/renderer/autofill_agent.h
@@ -13,6 +13,7 @@
 #include "base/memory/weak_ptr.h"
 #include "base/time.h"
 #include "base/timer.h"
+#include "components/autofill/common/forms_seen_param.h"
 #include "components/autofill/renderer/form_cache.h"
 #include "components/autofill/renderer/page_click_listener.h"
 #include "content/public/renderer/render_view_observer.h"
@@ -206,6 +207,8 @@ class AutofillAgent : public content::RenderViewObserver,
   // Hides any currently showing Autofill UI in the browser only.
   void HideHostAutofillUi();
 
+  void SendDynamicFormsSeen();
+
   FormCache form_cache_;
 
   PasswordAutofillManager* password_autofill_manager_;  // WEAK reference.
@@ -256,6 +259,10 @@ class AutofillAgent : public content::RenderViewObserver,
   // Whether or not |topmost_frame_| is whitelisted for Autocheckout.
   bool is_whitelisted_for_autocheckout_;
 
+  // Whether or not new forms/fields have been dynamically added
+  // post-document load.
+  bool forms_have_changed_since_load_;

[Ilya Sherman, 2013/04/06 00:29:39]

You should make sure to initialize this in the initializer list for the class's
constructor.

[Ilya Sherman, 2013/04/06 00:29:39]

nit: This variable is actually tracking whether or not the AutofillManager has
been alerted of the latest state of the forms.  Please consider renaming
accordingly.

[Dane Wallinga, 2013/04/08 22:55:50]

Done.

[Dane Wallinga, 2013/04/08 22:55:50]

Done.

+
   // Whether or not to ignore text changes.  Useful for when we're committing
   // a composition when we are defocusing the WebView and we don't want to
   // trigger an autofill popup to show.
@@ -266,9 +273,13 @@ class AutofillAgent : public content::RenderViewObserver,
 
   base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;
 
+  virtual void didAssociateFormControls(
+      const WebKit::WebVector<WebKit::WebNode>& nodes) OVERRIDE;

[Ilya Sherman, 2013/04/06 00:29:39]

nit: This should be grouped with whatever set of methods it's overriding, under
a "// Foo implementation." section.  It should also be above the instance
variables for this class.

[Dane Wallinga, 2013/04/08 22:55:50]

Done.

+
   friend class PasswordAutofillManagerTest;
   FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, FillFormElement);
   FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, SendForms);
+  FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, SendDynamicForms);
   FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, ShowAutofillWarning);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, WaitUsername);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, SuggestionAccept);