Requery the autofill server when forms and input fields are dynamically added.

components/autofill/renderer/autofill_agent.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_RENDERER_AUTOFILL_AGENT_H_
 #define COMPONENTS_AUTOFILL_RENDERER_AUTOFILL_AGENT_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time.h"
 #include "base/timer.h"
+#include "components/autofill/common/forms_seen_param.h"
 #include "components/autofill/renderer/form_cache.h"
 #include "components/autofill/renderer/page_click_listener.h"
 #include "content/public/renderer/render_view_observer.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebAutofillClient.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFormElement.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputElement.h"
 
 struct FormFieldData;
 
 namespace WebKit {
@@ skipping 173 matching lines @@
 
   // Set |node| to display the given |value|.
   void SetNodeText(const string16& value, WebKit::WebInputElement* node);
 
   // Hides any currently showing Autofill UI in the renderer or browser.
   void HideAutofillUi();
 
   // Hides any currently showing Autofill UI in the browser only.
   void HideHostAutofillUi();
 
+  void SendDynamicFormsSeen();
+
   FormCache form_cache_;
 
   PasswordAutofillManager* password_autofill_manager_;  // WEAK reference.
 
   // The ID of the last request sent for form field Autofill.  Used to ignore
   // out of date responses.
   int autofill_query_id_;
 
   // The element corresponding to the last request sent for form field Autofill.
   WebKit::WebInputElement element_;
@@ skipping 30 matching lines @@
   // Watchdog timer for clicking in Autocheckout flows.
   base::OneShotTimer<AutofillAgent> click_timer_;
 
   // Used to signal that we need to watch for loading failures in an
   // Autocheckout flow.
   bool autocheckout_click_in_progress_;
 
   // Whether or not |topmost_frame_| is whitelisted for Autocheckout.
   bool is_whitelisted_for_autocheckout_;
 
+  // Whether or not new forms/fields have been dynamically added
+  // post-document load.
+  bool forms_have_changed_since_load_;

[Ilya Sherman, 2013/04/06 00:29:39]

You should make sure to initialize this in the initializer list for the class's
constructor.

[Ilya Sherman, 2013/04/06 00:29:39]

nit: This variable is actually tracking whether or not the AutofillManager has
been alerted of the latest state of the forms.  Please consider renaming
accordingly.

[Dane Wallinga, 2013/04/08 22:55:50]

Done.

[Dane Wallinga, 2013/04/08 22:55:50]

Done.

+
   // Whether or not to ignore text changes.  Useful for when we're committing
   // a composition when we are defocusing the WebView and we don't want to
   // trigger an autofill popup to show.
   bool ignore_text_changes_;
 
   // Timestamp of first time forms are seen.
   base::TimeTicks forms_seen_timestamp_;
 
   base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;
 
+  virtual void didAssociateFormControls(
+      const WebKit::WebVector<WebKit::WebNode>& nodes) OVERRIDE;

[Ilya Sherman, 2013/04/06 00:29:39]

nit: This should be grouped with whatever set of methods it's overriding, under
a "// Foo implementation." section.  It should also be above the instance
variables for this class.

[Dane Wallinga, 2013/04/08 22:55:50]

Done.

+
   friend class PasswordAutofillManagerTest;
   FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, FillFormElement);
   FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, SendForms);
+  FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, SendDynamicForms);
   FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, ShowAutofillWarning);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, WaitUsername);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, SuggestionAccept);
   FRIEND_TEST_ALL_PREFIXES(PasswordAutofillManagerTest, SuggestionSelect);
 
   DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_RENDERER_AUTOFILL_AGENT_H_