Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: components/autofill/common/forms_seen_param.h

Issue 13264002: Requery the autofill server when forms and input fields are dynamically added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more fixes. you get the drill. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/common/forms_seen_param.h
diff --git a/components/autofill/common/forms_seen_param.h b/components/autofill/common/forms_seen_param.h
new file mode 100644
index 0000000000000000000000000000000000000000..94defaa2152a2d73e9ec4d0725a1705d16f590e0
--- /dev/null
+++ b/components/autofill/common/forms_seen_param.h
@@ -0,0 +1,25 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_AUTOFILL_COMMON_FORMS_SEEN_PARAM_H_
+#define COMPONENTS_AUTOFILL_COMMON_FORMS_SEEN_PARAM_H_
+
+namespace autofill {
+
+// Params to be sent with a FormsSeen message to AutofillManager.
Ilya Sherman 2013/04/06 00:29:39 nit: "Params" -> "Param", though I would actually
Dane Wallinga 2013/04/10 00:19:13 Done.
Dane Wallinga 2013/04/10 00:19:13 Done.
+// Specifies the nature of the forms triggering the call.
+enum FormsSeenParam {
Ilya Sherman 2013/04/06 00:29:39 nit: Perhaps "FormsSeenStatus"?
Dane Wallinga 2013/04/08 22:55:50 Doesn't feel right. AutofillManager needs to know
Ilya Sherman 2013/04/09 02:17:46 It's not the status of the forms; it's the status
Dane Wallinga 2013/04/10 00:19:13 Done.
+ // Forms present on page load with no additional unsent forms.
+ NO_SPECIAL_FORMS_SEEN = 0,
+ // If this an Autocheckout page, there are more that should be checked.
+ PARTIAL_FORMS_SEEN = 1,
+ // Forms were added dynamically post-page load.
+ DYNAMIC_FORMS_SEEN = 2,
+ // PARTIAL_FORMS_SEEN + DYNAMIC_FORMS_SEEN
+ PARTIAL_AND_DYNAMIC_FORMS_SEEN = 3,
+};
+
+} // namespace autofill
+
+#endif // COMPONENTS_AUTOFILL_COMMON_FORMS_SEEN_PARAM_H_

Powered by Google App Engine
This is Rietveld 408576698