components/autofill/common/forms_seen_param.h - Issue 13264002: Requery the autofill server when forms and input fields are dynamically added.

Side by Side Diff: components/autofill/common/forms_seen_param.h

Issue 13264002: Requery the autofill server when forms and input fields are dynamically added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more fixes. you get the drill. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/autofill/browser/autofill_manager.cc ('K') | « components/autofill/common/autofill_messages.h ('k') | components/autofill/renderer/autofill_agent.h » ('j') | components/autofill/renderer/autofill_agent.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_AUTOFILL_COMMON_FORMS_SEEN_PARAM_H_

	6 #define COMPONENTS_AUTOFILL_COMMON_FORMS_SEEN_PARAM_H_

	7

	8 namespace autofill {

	9

	10 // Params to be sent with a FormsSeen message to AutofillManager.
	Ilya Sherman 2013/04/06 00:29:39 nit: "Params" -> "Param", though I would actually nit: "Params" -> "Param", though I would actually drop this entire sentence. Dane Wallinga 2013/04/10 00:19:13 Done. Show quoted text On 2013/04/06 00:29:39, Ilya Sherman wrote: > nit: "Params" -> "Param", though I would actually drop this entire sentence. Done. Dane Wallinga 2013/04/10 00:19:13 Done. Show quoted text On 2013/04/06 00:29:39, Ilya Sherman wrote: > nit: "Params" -> "Param", though I would actually drop this entire sentence. Done.
	11 // Specifies the nature of the forms triggering the call.

	12 enum FormsSeenParam {
	Ilya Sherman 2013/04/06 00:29:39 nit: Perhaps "FormsSeenStatus"? nit: Perhaps "FormsSeenStatus"? Dane Wallinga 2013/04/08 22:55:50 Doesn't feel right. AutofillManager needs to know Show quoted text On 2013/04/06 00:29:39, Ilya Sherman wrote: > nit: Perhaps "FormsSeenStatus"? Doesn't feel right. AutofillManager needs to know how the forms were created, but I wouldn't describe that as having anything to do with the 'status' of the forms. Ilya Sherman 2013/04/09 02:17:46 It's not the status of the forms; it's the status Show quoted text On 2013/04/08 22:55:50, dgwallinga wrote: > On 2013/04/06 00:29:39, Ilya Sherman wrote: > > nit: Perhaps "FormsSeenStatus"? > Doesn't feel right. AutofillManager needs to know how the forms were created, > but I wouldn't describe that as having anything to do with the 'status' of the > forms. It's not the status of the forms; it's the status (or "state", if you prefer) of the renderer-side form manager (a.k.a. the AutofillAgent). Feel free to come up with a better name. Just don't leave it as "Param", which is too generic. Dane Wallinga 2013/04/10 00:19:13 Done. Show quoted text On 2013/04/09 02:17:46, Ilya Sherman wrote: > On 2013/04/08 22:55:50, dgwallinga wrote: > > On 2013/04/06 00:29:39, Ilya Sherman wrote: > > > nit: Perhaps "FormsSeenStatus"? > > Doesn't feel right. AutofillManager needs to know how the forms were created, > > but I wouldn't describe that as having anything to do with the 'status' of the > > forms. > > It's not the status of the forms; it's the status (or "state", if you prefer) of > the renderer-side form manager (a.k.a. the AutofillAgent). Feel free to come up > with a better name. Just don't leave it as "Param", which is too generic. Done.
	13 // Forms present on page load with no additional unsent forms.

	14 NO_SPECIAL_FORMS_SEEN = 0,

	15 // If this an Autocheckout page, there are more that should be checked.

	16 PARTIAL_FORMS_SEEN = 1,

	17 // Forms were added dynamically post-page load.

	18 DYNAMIC_FORMS_SEEN = 2,

	19 // PARTIAL_FORMS_SEEN + DYNAMIC_FORMS_SEEN

	20 PARTIAL_AND_DYNAMIC_FORMS_SEEN = 3,

	21 };

	22

	23 } // namespace autofill

	24

	25 #endif // COMPONENTS_AUTOFILL_COMMON_FORMS_SEEN_PARAM_H_

OLD	NEW