Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1320553002: [Cleanup] Remove the no longer used GoogleSearch.AccessPoint metric. (Closed)

Created:
5 years, 3 months ago by Ilya Sherman
Modified:
5 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Remove the no longer used GoogleSearch.AccessPoint metric. This metric has a bug in its implementation. Since there don't seem to be any clients relying on this metric, it's time to just remove it and the supporting code. BUG=421631 TEST=none R=kmadhusu@chromium.org Committed: https://crrev.com/fb441084a631df8c3681b74154f159e0303f409f Cr-Commit-Position: refs/heads/master@{#348924}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Remove a stale forward declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -694 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 2 chunks +2 lines, -7 lines 0 comments Download
D chrome/browser/google/google_search_counter.h View 1 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/google/google_search_counter.cc View 1 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/browser/google/google_search_counter_android.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/google/google_search_counter_android.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/google/google_search_counter_android_unittest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D chrome/browser/google/google_search_counter_unittest.cc View 1 chunk +0 lines, -149 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/google.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/google/core/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/google/core/browser/google_search_metrics.h View 1 chunk +0 lines, -45 lines 0 comments Download
D components/google/core/browser/google_search_metrics.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Ilya Sherman
5 years, 3 months ago (2015-08-26 00:05:19 UTC) #1
Ilya Sherman
kmadhusu, ping =)
5 years, 3 months ago (2015-09-01 03:12:26 UTC) #2
kmadhusu
(Added asvitkine@ to the reviewers list). LGTM. Sorry for the late reply. I missed the ...
5 years, 3 months ago (2015-09-11 16:41:14 UTC) #4
Ilya Sherman
Lei, PTAL at the chrome_browser_main files. Peter, PTAL at the google files.
5 years, 3 months ago (2015-09-11 20:00:41 UTC) #6
Lei Zhang
lgtm https://chromiumcodereview.appspot.com/1320553002/diff/1/chrome/browser/chrome_browser_main_android.h File chrome/browser/chrome_browser_main_android.h (right): https://chromiumcodereview.appspot.com/1320553002/diff/1/chrome/browser/chrome_browser_main_android.h#newcode10 chrome/browser/chrome_browser_main_android.h:10: class GoogleSearchCounterAndroid; remove
5 years, 3 months ago (2015-09-11 20:05:49 UTC) #7
Alexei Svitkine (slow)
lgtm
5 years, 3 months ago (2015-09-11 20:08:07 UTC) #8
Ilya Sherman
https://chromiumcodereview.appspot.com/1320553002/diff/1/chrome/browser/chrome_browser_main_android.h File chrome/browser/chrome_browser_main_android.h (right): https://chromiumcodereview.appspot.com/1320553002/diff/1/chrome/browser/chrome_browser_main_android.h#newcode10 chrome/browser/chrome_browser_main_android.h:10: class GoogleSearchCounterAndroid; On 2015/09/11 20:05:49, Lei Zhang wrote: > ...
5 years, 3 months ago (2015-09-11 20:37:43 UTC) #9
Peter Kasting
RS LGTM on pure code removal
5 years, 3 months ago (2015-09-14 23:45:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1320553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1320553002/40001
5 years, 3 months ago (2015-09-15 16:00:44 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-15 17:41:19 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/fb441084a631df8c3681b74154f159e0303f409f Cr-Commit-Position: refs/heads/master@{#348924}
5 years, 3 months ago (2015-09-15 17:42:01 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:46:33 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fb441084a631df8c3681b74154f159e0303f409f
Cr-Commit-Position: refs/heads/master@{#348924}

Powered by Google App Engine
This is Rietveld 408576698