Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5205)

Unified Diff: chrome/browser/google/google_search_counter.cc

Issue 1320553002: [Cleanup] Remove the no longer used GoogleSearch.AccessPoint metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove a stale forward declaration Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google/google_search_counter.cc
diff --git a/chrome/browser/google/google_search_counter.cc b/chrome/browser/google/google_search_counter.cc
deleted file mode 100644
index 46392fdce0f6c90c59f5b7833c1cac7451a5a6ce..0000000000000000000000000000000000000000
--- a/chrome/browser/google/google_search_counter.cc
+++ /dev/null
@@ -1,100 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/google/google_search_counter.h"
-
-#include "base/logging.h"
-#include "components/google/core/browser/google_util.h"
-#include "content/public/browser/navigation_controller.h"
-#include "content/public/browser/navigation_details.h"
-#include "content/public/browser/navigation_entry.h"
-#include "content/public/browser/notification_service.h"
-#include "content/public/browser/notification_types.h"
-
-// static
-void GoogleSearchCounter::RegisterForNotifications() {
- GoogleSearchCounter::GetInstance()->RegisterForNotificationsInternal();
-}
-
-// static
-GoogleSearchCounter* GoogleSearchCounter::GetInstance() {
- return base::Singleton<GoogleSearchCounter>::get();
-}
-
-GoogleSearchMetrics::AccessPoint
-GoogleSearchCounter::GetGoogleSearchAccessPointForSearchNavEntry(
- const content::NavigationEntry& entry) const {
- DCHECK(google_util::IsGoogleSearchUrl(entry.GetURL()));
-
- // If the |entry| is FROM_ADDRESS_BAR, it comes from the omnibox; if it's
- // GENERATED, the user was doing a search, rather than doing a navigation to a
- // search URL (e.g. from hisotry, or pasted in).
- if (entry.GetTransitionType() == (ui::PAGE_TRANSITION_GENERATED |
- ui::PAGE_TRANSITION_FROM_ADDRESS_BAR)) {
- return GoogleSearchMetrics::AP_OMNIBOX;
- }
-
- // The string "source=search_app" in the |entry| URL represents a Google
- // search from the Google Search App.
- if (entry.GetURL().query().find("source=search_app") != std::string::npos)
- return GoogleSearchMetrics::AP_SEARCH_APP;
-
- // For all other cases that we have not yet implemented or care to measure, we
- // log a generic "catch-all" metric.
- return GoogleSearchMetrics::AP_OTHER;
-}
-
-bool GoogleSearchCounter::ShouldRecordCommittedDetails(
- const content::NotificationDetails& details) const {
- const content::LoadCommittedDetails* commit =
- content::Details<content::LoadCommittedDetails>(details).ptr();
- return google_util::IsGoogleSearchUrl(commit->entry->GetURL());
-}
-
-GoogleSearchCounter::GoogleSearchCounter()
- : search_metrics_(new GoogleSearchMetrics) {
-}
-
-GoogleSearchCounter::~GoogleSearchCounter() {
-}
-
-void GoogleSearchCounter::ProcessCommittedEntry(
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
- // Note that GoogleSearchMetrics logs metrics through UMA, which will only
- // transmit these counts to the server if the user has opted into sending
- // usage stats.
- const content::LoadCommittedDetails* commit =
- content::Details<content::LoadCommittedDetails>(details).ptr();
- const content::NavigationEntry& entry = *commit->entry;
- if (ShouldRecordCommittedDetails(details)) {
- search_metrics_->RecordGoogleSearch(
- GetGoogleSearchAccessPointForSearchNavEntry(entry));
- }
-}
-
-void GoogleSearchCounter::SetSearchMetricsForTesting(
- GoogleSearchMetrics* search_metrics) {
- DCHECK(search_metrics);
- search_metrics_.reset(search_metrics);
-}
-
-void GoogleSearchCounter::RegisterForNotificationsInternal() {
- // We always listen for all COMMITTED navigations from all sources, as any
- // one of them could be a navigation of interest.
- registrar_.Add(this, content::NOTIFICATION_NAV_ENTRY_COMMITTED,
- content::NotificationService::AllSources());
-}
-
-void GoogleSearchCounter::Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
- switch (type) {
- case content::NOTIFICATION_NAV_ENTRY_COMMITTED:
- ProcessCommittedEntry(source, details);
- break;
- default:
- NOTREACHED();
- }
-}
« no previous file with comments | « chrome/browser/google/google_search_counter.h ('k') | chrome/browser/google/google_search_counter_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698