Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5984)

Unified Diff: chrome/browser/google/google_search_counter.h

Issue 1320553002: [Cleanup] Remove the no longer used GoogleSearch.AccessPoint metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove a stale forward declaration Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main_android.cc ('k') | chrome/browser/google/google_search_counter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google/google_search_counter.h
diff --git a/chrome/browser/google/google_search_counter.h b/chrome/browser/google/google_search_counter.h
deleted file mode 100644
index ed6f24484f4d40fc82fe8c016b08a68876a02787..0000000000000000000000000000000000000000
--- a/chrome/browser/google/google_search_counter.h
+++ /dev/null
@@ -1,72 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_GOOGLE_GOOGLE_SEARCH_COUNTER_H_
-#define CHROME_BROWSER_GOOGLE_GOOGLE_SEARCH_COUNTER_H_
-
-#include "base/memory/singleton.h"
-#include "components/google/core/browser/google_search_metrics.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
-
-namespace content {
-class NavigationEntry;
-}
-
-// A listener for counting Google searches from various search access points. No
-// actual search query content is observed. See GoogleSearchMetrics for more
-// details about these access points.
-class GoogleSearchCounter : content::NotificationObserver {
- public:
- // Initialize the global instance.
- static void RegisterForNotifications();
-
- // Return the singleton instance of GoogleSearchCounter.
- static GoogleSearchCounter* GetInstance();
-
- // Returns the Google search access point for the given |entry|. This method
- // assumes that we have already verified that |entry|'s URL is a Google search
- // URL.
- GoogleSearchMetrics::AccessPoint GetGoogleSearchAccessPointForSearchNavEntry(
- const content::NavigationEntry& entry) const;
-
- // Returns true if |details| is valid and corresponds to a search results
- // page.
- bool ShouldRecordCommittedDetails(
- const content::NotificationDetails& details) const;
-
- const GoogleSearchMetrics* search_metrics() const {
- return search_metrics_.get();
- }
-
- private:
- friend struct base::DefaultSingletonTraits<GoogleSearchCounter>;
- friend class GoogleSearchCounterTest;
- friend class GoogleSearchCounterAndroidTest;
-
- GoogleSearchCounter();
- ~GoogleSearchCounter() override;
-
- void ProcessCommittedEntry(const content::NotificationSource& source,
- const content::NotificationDetails& details);
-
- // Replace the internal metrics object with a dummy or a mock. This instance
- // takes ownership of |search_metrics|.
- void SetSearchMetricsForTesting(GoogleSearchMetrics* search_metrics);
-
- // Register this counter for all notifications we care about.
- void RegisterForNotificationsInternal();
-
- // content::NotificationObserver
- void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
-
- content::NotificationRegistrar registrar_;
- scoped_ptr<GoogleSearchMetrics> search_metrics_;
-
- DISALLOW_COPY_AND_ASSIGN(GoogleSearchCounter);
-};
-
-#endif // CHROME_BROWSER_GOOGLE_GOOGLE_SEARCH_COUNTER_H_
« no previous file with comments | « chrome/browser/chrome_browser_main_android.cc ('k') | chrome/browser/google/google_search_counter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698