Issue 13065006: cc: Add DISALLOW_COPY_AND_ASSIGN where appropriate.

Issue 13065006: cc: Add DISALLOW_COPY_AND_ASSIGN where appropriate. (Closed)

Created:
7 years, 9 months ago by danakj

Modified:
7 years, 9 months ago

Reviewers:
jamesr

CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org, piman, backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Add DISALLOW_COPY_AND_ASSIGN where appropriate. Also DISALLOW_IMPLICIT_CONSTRUCTORS in a few places instead. NOTRY=true R=jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190989

Patch Set 1 : #

Patch Set 2 : git cl try #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : fix windows, add copy con for MTS::DrawingState back #

Patch Set 6 : Add operator= for DrawingState back as well #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -2 lines)			Patch
M	cc/animation/animation_id_provider.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	cc/animation/scrollbar_animation_controller_linear_fade.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/animation/timing_function.h	View	1 2 3	2 chunks	+18 lines, -0 lines	0 comments	Download
M	cc/animation/transform_operations.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/debug/debug_colors.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/debug/fake_web_graphics_context_3d.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	cc/debug/ring_buffer.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/input/pinch_zoom_scrollbar.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/input/pinch_zoom_scrollbar_geometry.h	View	1 2	3 chunks	+5 lines, -0 lines	0 comments	Download
M	cc/input/pinch_zoom_scrollbar_painter.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	cc/layers/contents_scaling_layer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/delegated_renderer_layer.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/delegated_renderer_layer_impl.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/heads_up_display_layer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/io_surface_layer.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/nine_patch_layer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/nine_patch_layer_impl.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/picture_image_layer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/picture_layer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/scrollbar_geometry_fixed_thumb.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/scrollbar_layer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/scrollbar_layer_impl.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	cc/layers/solid_color_layer.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/solid_color_layer_impl.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/layers/video_layer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/output/compositor_frame.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	cc/output/compositor_frame_ack.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	cc/output/delegated_frame_data.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	cc/output/geometry_binding.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	cc/output/program_binding.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	cc/output/render_surface_filters.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	cc/output/shader.h	View		20 chunks	+40 lines, -0 lines	0 comments	Download
M	cc/output/shader.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	cc/resources/picture_layer_tiling.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	cc/resources/picture_layer_tiling_set.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/resources/platform_color.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	cc/resources/priority_calculator.h	View	1 2	3 chunks	+6 lines, -0 lines	0 comments	Download
M	cc/resources/resource.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/resources/tile.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cc/trees/proxy.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	cc/trees/thread_proxy.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm=pong https://codereview.chromium.org/13065006/diff/10001/cc/animation/timing_function.h File cc/animation/timing_function.h (right): https://codereview.chromium.org/13065006/diff/10001/cc/animation/timing_function.h#newcode56 cc/animation/timing_function.h:56: DISALLOW_COPY_AND_ASSIGN(EaseTimingFunction); why not DISALLOW_IMPLICIT_... here?

7 years, 9 months ago (2013-03-26 22:06:03 UTC) #3

danakj

https://codereview.chromium.org/13065006/diff/10001/cc/animation/timing_function.h File cc/animation/timing_function.h (right): https://codereview.chromium.org/13065006/diff/10001/cc/animation/timing_function.h#newcode56 cc/animation/timing_function.h:56: DISALLOW_COPY_AND_ASSIGN(EaseTimingFunction); On 2013/03/26 22:06:03, jamesr wrote: > why not ...

7 years, 9 months ago (2013-03-26 22:20:49 UTC) #4