chrome/browser/notifications/notification_conversion_helper_unittest.cc - Issue 1292003004: Elide origins displayed on web notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_conversion_helper_unittest.cc

Issue 1292003004: Elide origins displayed on web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Style nit Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification.cc ('k') | chrome/browser/notifications/platform_notification_service_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_conversion_helper_unittest.cc

diff --git a/chrome/browser/notifications/notification_conversion_helper_unittest.cc b/chrome/browser/notifications/notification_conversion_helper_unittest.cc

index acc2d2463353344050cb666eea851e2e4bae3bde..d251b2fc04abb1fb4ed6872c61ae1dad2e50a60c 100644

--- a/chrome/browser/notifications/notification_conversion_helper_unittest.cc

+++ b/chrome/browser/notifications/notification_conversion_helper_unittest.cc

@@ -57,16 +57,11 @@ class NotificationConversionHelperTest : public testing::Test {

gfx::Image icon = gfx::Image::CreateFrom1xBitmap(bitmap);

scoped_ptr<Notification> notification(new Notification(

- type,

- GURL(),

- base::UTF8ToUTF16("Title"),

- base::UTF8ToUTF16("This is a message."),

- icon,

+ type, base::UTF8ToUTF16("Title"),

+ base::UTF8ToUTF16("This is a message."), icon,

message_center::NotifierId(message_center::NotifierId::APPLICATION,

"Notifier 1"),

- base::UTF8ToUTF16("Notifier's Name"),

- "id1",

- optional_fields,

+ base::UTF8ToUTF16("Notifier's Name"), GURL(), "id1", optional_fields,

delegate));

return notification.Pass();