chrome/browser/notifications/platform_notification_service_browsertest.cc - Issue 1292003004: Elide origins displayed on web notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_browsertest.cc

Issue 1292003004: Elide origins displayed on web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Style nit Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_conversion_helper_unittest.cc ('k') | chrome/browser/notifications/platform_notification_service_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/platform_notification_service_browsertest.cc

diff --git a/chrome/browser/notifications/platform_notification_service_browsertest.cc b/chrome/browser/notifications/platform_notification_service_browsertest.cc

index 724245be752f47cf27de264fd4dfc78b93a4f930..b90dec69f9830a3e9b01a21a9c1e65d13cf4ab10 100644

--- a/chrome/browser/notifications/platform_notification_service_browsertest.cc

+++ b/chrome/browser/notifications/platform_notification_service_browsertest.cc

@@ -287,8 +287,9 @@ IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,

const Notification& notification = ui_manager()->GetNotificationAt(0);

- EXPECT_EQ(base::UTF8ToUTF16(host_port.ToString()),

- notification.context_message());

+ EXPECT_TRUE(notification.context_message().empty());

+ EXPECT_EQ("https://" + host_port.ToString() + "/",

+ notification.origin_url().spec());

}

IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,