Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: chrome/browser/notifications/notification.cc

Issue 1292003004: Elide origins displayed on web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Style nit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification.cc
diff --git a/chrome/browser/notifications/notification.cc b/chrome/browser/notifications/notification.cc
index 89d81a7099f8446a81b863996f1d0b972fd2a285..076e780c2e67a40fef3a0e49c601901b5dc5d1c3 100644
--- a/chrome/browser/notifications/notification.cc
+++ b/chrome/browser/notifications/notification.cc
@@ -17,21 +17,21 @@ Notification::Notification(const GURL& origin_url,
body,
icon,
display_source,
+ origin_url,
message_center::NotifierId(origin_url),
message_center::RichNotificationData(),
delegate),
- origin_url_(origin_url),
tag_(tag),
delegate_(delegate) {}
Notification::Notification(
message_center::NotificationType type,
- const GURL& origin_url,
const base::string16& title,
const base::string16& body,
const gfx::Image& icon,
const message_center::NotifierId& notifier_id,
const base::string16& display_source,
+ const GURL& origin_url,
const std::string& tag,
const message_center::RichNotificationData& rich_notification_data,
NotificationDelegate* delegate)
@@ -41,24 +41,22 @@ Notification::Notification(
body,
icon,
display_source,
+ origin_url,
notifier_id,
rich_notification_data,
delegate),
- origin_url_(origin_url),
tag_(tag),
delegate_(delegate) {}
Notification::Notification(const std::string& id,
const Notification& notification)
: message_center::Notification(id, notification),
- origin_url_(notification.origin_url()),
tag_(notification.tag()),
delegate_(notification.delegate()) {
}
Notification::Notification(const Notification& notification)
: message_center::Notification(notification),
- origin_url_(notification.origin_url()),
tag_(notification.tag()),
delegate_(notification.delegate()) {}
@@ -66,7 +64,6 @@ Notification::~Notification() {}
Notification& Notification::operator=(const Notification& notification) {
message_center::Notification::operator=(notification);
- origin_url_ = notification.origin_url();
tag_ = notification.tag();
delegate_ = notification.delegate();
return *this;
« no previous file with comments | « chrome/browser/notifications/notification.h ('k') | chrome/browser/notifications/notification_conversion_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698