Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3365)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/javac.py

Issue 12913028: Output better error messages during build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/jar.py ('k') | build/android/process_resources.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/javac.py
diff --git a/build/android/javac.py b/build/android/javac.py
index 1ba5d064f8d18a5ee86c12aa1b5e996b41ddc52f..9adf5664bdfb917f75c897f1058f9e53815bc8ec 100755
--- a/build/android/javac.py
+++ b/build/android/javac.py
@@ -7,7 +7,6 @@
import fnmatch
import optparse
import os
-import subprocess
import sys
from pylib import build_utils
@@ -41,7 +40,7 @@ def DoJavac(options):
build_utils.DeleteDirectory(output_dir)
build_utils.MakeDirectory(output_dir)
- subprocess.check_call([
+ build_utils.CheckCallDie([
'javac',
'-g',
'-Xlint:unchecked',
« no previous file with comments | « build/android/jar.py ('k') | build/android/process_resources.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698