Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5862)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/jar.py

Issue 12913028: Output better error messages during build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/dex.py ('k') | build/android/javac.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/jar.py
diff --git a/build/android/jar.py b/build/android/jar.py
index fa5591d54e65206d902197cfc12ddec591457afa..9120a7902054ef5dd06ef4b5dbd2f28cde801af5 100755
--- a/build/android/jar.py
+++ b/build/android/jar.py
@@ -7,7 +7,6 @@
import fnmatch
import optparse
import os
-import subprocess
import sys
from pylib import build_utils
@@ -27,7 +26,7 @@ def DoJar(options):
jar_cwd = options.classes_dir
class_files = [os.path.relpath(f, jar_cwd) for f in class_files]
jar_cmd = ['jar', 'cf0', jar_path] + class_files
- subprocess.check_call(jar_cmd, cwd=jar_cwd)
+ build_utils.CheckCallDie(jar_cmd, cwd=jar_cwd)
def main(argv):
« no previous file with comments | « build/android/dex.py ('k') | build/android/javac.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698