Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: build/android/process_resources.py

Issue 12913028: Output better error messages during build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/javac.py ('k') | build/android/pylib/build_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/process_resources.py
diff --git a/build/android/process_resources.py b/build/android/process_resources.py
index c6619c52935fbc940d88b5fb45d128f8e98f1334..541fb56063ed8fd523cfd8e9b6786a79f8140b2c 100755
--- a/build/android/process_resources.py
+++ b/build/android/process_resources.py
@@ -9,7 +9,6 @@
import optparse
import os
import shlex
-import subprocess
from pylib import build_utils
@@ -80,17 +79,20 @@ def main():
package_command.append('--non-constant-id')
if options.custom_package:
package_command += ['--custom-package', options.custom_package]
- subprocess.check_call(package_command)
+ build_utils.CheckCallDie(package_command)
# Crunch image resources. This shrinks png files and is necessary for 9-patch
# images to display correctly.
build_utils.MakeDirectory(options.crunch_output_dir)
- subprocess.check_call([aapt,
- 'crunch',
- '-S', options.crunch_input_dir,
- '-C', options.crunch_output_dir])
- build_utils.Touch(options.stamp)
+ aapt_cmd = [aapt,
+ 'crunch',
+ '-S', options.crunch_input_dir,
+ '-C', options.crunch_output_dir]
+ build_utils.CheckCallDie(aapt_cmd)
+
+ if options.stamp:
+ build_utils.Touch(options.stamp)
if __name__ == '__main__':
« no previous file with comments | « build/android/javac.py ('k') | build/android/pylib/build_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698