Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3024)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/dex.py

Issue 12913028: Output better error messages during build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/jar.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/dex.py
diff --git a/build/android/dex.py b/build/android/dex.py
index a447a993b637dbdcb3c6495da500832829f03475..00c2c527422bc96788ad7f2e8d0f8f1910fb46e8 100755
--- a/build/android/dex.py
+++ b/build/android/dex.py
@@ -7,7 +7,6 @@
import fnmatch
import optparse
import os
-import subprocess
import sys
from pylib import build_utils
@@ -16,7 +15,7 @@ from pylib import build_utils
def DoDex(options, paths):
dx_binary = os.path.join(options.android_sdk_root, 'platform-tools', 'dx')
dex_cmd = [dx_binary, '--dex', '--output', options.dex_path] + paths
- subprocess.check_call(dex_cmd)
+ build_utils.CheckCallDie(dex_cmd)
def main(argv):
« no previous file with comments | « no previous file | build/android/jar.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698