Change findbugs modifications from presubmit error->warning

Change findbugs modifications from presubmit error->warning

While we want to bring this list down, blocking commits in this manner
with false positives, is too limiting.

BUG=180981
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188189

[Yaron, 2013-03-14 19:33:22]

As penance, I'll fix some of these

[joth, 2013-03-14 20:07:35]

lgtm, lets see if the warning is sufficient to stop it growing uncontrolled.

Still -
Do you have some examples of false positives?
If we don't care about them, should we just disable them in
findbugs_exclude.xml?
In most cases I've found the warning-hiding fix is so simple though, I'm
surprised it's a problem.



On 14 March 2013 12:33, <yfriedman@chromium.org> wrote:

> Reviewers: joth,
>
> Message:
> As penance, I'll fix some of these
>
> Description:
> Change findbugs modifications from presubmit error->warning
>
> While we want to bring this list down, blocking commits in this manner
> with false positives, is too limiting.
>
> BUG=180981
>
>
> Please review this at
https://codereview.chromium.**org/12825011/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M build/android/PRESUBMIT.py
>
>
> Index: build/android/PRESUBMIT.py
> diff --git a/build/android/PRESUBMIT.py b/build/android/PRESUBMIT.py
> index fceeec3eab6e7876b7b3e14c1a096b**292e780c81..**
> 2751f4a394ef63d74f9c962b72dee3**700c8e89e3 100644
> --- a/build/android/PRESUBMIT.py
> +++ b/build/android/PRESUBMIT.py
> @@ -16,15 +16,15 @@ _DELETIONS_ONLY_FILES = (
>  def _CheckDeletionsOnlyFiles(**input_api, output_api):
>    """Check that a certain listed files only have deletions.
>    """
> -  errors = []
> +  warnings = []
>    for f in input_api.AffectedFiles():
>      if f.LocalPath() in _DELETIONS_ONLY_FILES:
>        if f.ChangedContents():
> -        errors.append(f.LocalPath())
> +        warnings.append(f.LocalPath())
>    results = []
> -  if errors:
> -    results.append(output_api.**PresubmitError(
> -        'Following files should only contain deletions.', errors))
> +  if warnings:
> +    results.append(output_api.**PresubmitPromptWarning(
> +        'Following files should only contain deletions.', warnings))
>    return results
>
>
>
>
>

[Yaron, 2013-03-14 20:14:19]

Findbugs itself mostly doesn't have false positives. There are some in the java
bridge code but that's because it's using reflection, and I agree that we could
findbugs_exclude them. My beef with the presubmit is that any + lines (including
from rename/move) is treated as a failure

[commit-bot: I haz the power, 2013-03-14 20:17:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/12825011/1

[commit-bot: I haz the power, 2013-03-14 20:57:25]

Change committed as 188189