Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: build/android/PRESUBMIT.py

Issue 12825011: Change findbugs modifications from presubmit error->warning (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/PRESUBMIT.py
diff --git a/build/android/PRESUBMIT.py b/build/android/PRESUBMIT.py
index fceeec3eab6e7876b7b3e14c1a096b292e780c81..2751f4a394ef63d74f9c962b72dee3700c8e89e3 100644
--- a/build/android/PRESUBMIT.py
+++ b/build/android/PRESUBMIT.py
@@ -16,15 +16,15 @@ _DELETIONS_ONLY_FILES = (
def _CheckDeletionsOnlyFiles(input_api, output_api):
"""Check that a certain listed files only have deletions.
"""
- errors = []
+ warnings = []
for f in input_api.AffectedFiles():
if f.LocalPath() in _DELETIONS_ONLY_FILES:
if f.ChangedContents():
- errors.append(f.LocalPath())
+ warnings.append(f.LocalPath())
results = []
- if errors:
- results.append(output_api.PresubmitError(
- 'Following files should only contain deletions.', errors))
+ if warnings:
+ results.append(output_api.PresubmitPromptWarning(
+ 'Following files should only contain deletions.', warnings))
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698