| OLD | NEW |
| 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Presubmit script for android buildbot. | 5 """Presubmit script for android buildbot. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for |
| 8 details on the presubmit API built into gcl. | 8 details on the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| 11 _DELETIONS_ONLY_FILES = ( | 11 _DELETIONS_ONLY_FILES = ( |
| 12 'build/android/findbugs_filter/findbugs_known_bugs.txt', | 12 'build/android/findbugs_filter/findbugs_known_bugs.txt', |
| 13 ) | 13 ) |
| 14 | 14 |
| 15 | 15 |
| 16 def _CheckDeletionsOnlyFiles(input_api, output_api): | 16 def _CheckDeletionsOnlyFiles(input_api, output_api): |
| 17 """Check that a certain listed files only have deletions. | 17 """Check that a certain listed files only have deletions. |
| 18 """ | 18 """ |
| 19 errors = [] | 19 warnings = [] |
| 20 for f in input_api.AffectedFiles(): | 20 for f in input_api.AffectedFiles(): |
| 21 if f.LocalPath() in _DELETIONS_ONLY_FILES: | 21 if f.LocalPath() in _DELETIONS_ONLY_FILES: |
| 22 if f.ChangedContents(): | 22 if f.ChangedContents(): |
| 23 errors.append(f.LocalPath()) | 23 warnings.append(f.LocalPath()) |
| 24 results = [] | 24 results = [] |
| 25 if errors: | 25 if warnings: |
| 26 results.append(output_api.PresubmitError( | 26 results.append(output_api.PresubmitPromptWarning( |
| 27 'Following files should only contain deletions.', errors)) | 27 'Following files should only contain deletions.', warnings)) |
| 28 return results | 28 return results |
| 29 | 29 |
| 30 | 30 |
| 31 def CommonChecks(input_api, output_api): | 31 def CommonChecks(input_api, output_api): |
| 32 output = [] | 32 output = [] |
| 33 | 33 |
| 34 def J(*dirs): | 34 def J(*dirs): |
| 35 """Returns a path relative to presubmit directory.""" | 35 """Returns a path relative to presubmit directory.""" |
| 36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs) | 36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs) |
| 37 | 37 |
| 38 output.extend(input_api.canned_checks.RunPylint( | 38 output.extend(input_api.canned_checks.RunPylint( |
| 39 input_api, | 39 input_api, |
| 40 output_api, | 40 output_api, |
| 41 white_list=[r'PRESUBMIT\.py$', r'buildbot/.*\.py$'], | 41 white_list=[r'PRESUBMIT\.py$', r'buildbot/.*\.py$'], |
| 42 extra_paths_list=[ | 42 extra_paths_list=[ |
| 43 J(), J('..', '..', 'third_party', 'android_testrunner')])) | 43 J(), J('..', '..', 'third_party', 'android_testrunner')])) |
| 44 | 44 |
| 45 output.extend(input_api.canned_checks.RunUnitTestsInDirectory( | 45 output.extend(input_api.canned_checks.RunUnitTestsInDirectory( |
| 46 input_api, output_api, J('buildbot', 'tests'))) | 46 input_api, output_api, J('buildbot', 'tests'))) |
| 47 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api)) | 47 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api)) |
| 48 return output | 48 return output |
| 49 | 49 |
| 50 | 50 |
| 51 def CheckChangeOnUpload(input_api, output_api): | 51 def CheckChangeOnUpload(input_api, output_api): |
| 52 return CommonChecks(input_api, output_api) | 52 return CommonChecks(input_api, output_api) |
| 53 | 53 |
| 54 | 54 |
| 55 def CheckChangeOnCommit(input_api, output_api): | 55 def CheckChangeOnCommit(input_api, output_api): |
| 56 return CommonChecks(input_api, output_api) | 56 return CommonChecks(input_api, output_api) |
| OLD | NEW |