fix inconsistent firing of events for extension fields

fix inconsistent firing of events for extension fields

Before we would fire events for some extension field
mutations but not others. Change it to fire no events
for these fields for now.

(Using _setField consistently should make it easier to
send events later if we decide to do that.)

Also, remove the optional third argument to setField().
It shouldn't be part of the public API since it can
be used to defeat field validation.

BUG=
R=sgjesse@google.com

Committed: https://github.com/dart-lang/protobuf/commit/4d5fe5cd48e36d31a5dadb0ad83f5050e310383a

[skybrian, 2015-08-08 02:23:17]

skybrian@google.com changed reviewers:
+ sgjesse@google.com

[skybrian, 2015-08-08 02:23:17]

Depends on https://chromiumcodereview.appspot.com/1277863003/

[Søren Gjesse, 2015-08-10 13:37:19]

lgtm

https://chromiumcodereview.appspot.com/1282103003/diff/20001/lib/src/protobuf...
File lib/src/protobuf/generated_message.dart (right):

https://chromiumcodereview.appspot.com/1282103003/diff/20001/lib/src/protobuf...
lib/src/protobuf/generated_message.dart:948: void setField(int tagNumber, value)
{
This is a breaking change. Is the pubspec.yaml updated with a new version? Maybe
add information to the CHANGELOG.

[skybrian, 2015-08-10 18:25:13]

Committed patchset #2 (id:20001) manually as
4d5fe5cd48e36d31a5dadb0ad83f5050e310383a (presubmit successful).

[skybrian, 2015-08-10 18:26:12]

https://chromiumcodereview.appspot.com/1282103003/diff/20001/lib/src/protobuf...
File lib/src/protobuf/generated_message.dart (right):

https://chromiumcodereview.appspot.com/1282103003/diff/20001/lib/src/protobuf...
lib/src/protobuf/generated_message.dart:948: void setField(int tagNumber, value)
{
On 2015/08/10 13:37:19, Søren Gjesse wrote:
> This is a breaking change. Is the pubspec.yaml updated with a new version?
Maybe
> add information to the CHANGELOG.

Updated CHANGELOG. I will bump the version number before release.