Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: lib/src/protobuf/event_plugin.dart

Issue 1282103003: fix inconsistent firing of events for extension fields (Closed) Base URL: git@github.com:dart-lang/dart-protobuf.git@fieldtype
Patch Set: tweak a comment Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/protobuf/generated_message.dart » ('j') | lib/src/protobuf/generated_message.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/protobuf/event_plugin.dart
diff --git a/lib/src/protobuf/event_plugin.dart b/lib/src/protobuf/event_plugin.dart
index 44ed900ef9acf3376b8460a9e061d5e23e489021..028a051d4e6943bf6a8398ce20653827fb55570c 100644
--- a/lib/src/protobuf/event_plugin.dart
+++ b/lib/src/protobuf/event_plugin.dart
@@ -21,12 +21,12 @@ abstract class EventPlugin {
/// If false, GeneratedMessage will skip calls to event handlers.
bool get hasObservers;
- /// Called before setting a field if startGroup returned true.
+ /// Called before setting a non-extension field.
///
/// For repeated fields, this will be called in getField() when
/// the PbList is created.
void beforeSetField(int tag, newValue);
- /// Called before clearing a field if startGroup returned true.
+ /// Called before clearing a non-extension field.
void beforeClearField(int tag);
}
« no previous file with comments | « no previous file | lib/src/protobuf/generated_message.dart » ('j') | lib/src/protobuf/generated_message.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698