Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 12779010: Attempt to fix flake in FullTabDownloadTest.CF_DownloadFileFromPost. (Closed)

Created:
7 years, 9 months ago by grt (UTC plus 2)
Modified:
7 years, 9 months ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Visibility:
Public.

Description

Attempt to fix flake in FullTabDownloadTest.CF_DownloadFileFromPost. Increase timeout for the file to appear from 2s to 3s, and take a snapshot when it doesn't appear in time. BUG=189099 TEST=chrome_frame_tests.exe Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188401

Patch Set 1 : #

Patch Set 2 : motion to fix other test binaries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -19 lines) Patch
M chrome_frame/test/chrome_frame_test_utils.h View 1 3 chunks +4 lines, -16 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 1 2 chunks +24 lines, -0 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_actions.h View 1 3 chunks +3 lines, -1 line 0 comments Download
M chrome_frame/test/navigation_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
grt (UTC plus 2)
7 years, 9 months ago (2013-03-14 16:57:29 UTC) #1
robertshield
lgtm
7 years, 9 months ago (2013-03-14 21:06:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/12779010/2002
7 years, 9 months ago (2013-03-14 22:25:40 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 9 months ago (2013-03-15 00:08:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/12779010/19001
7 years, 9 months ago (2013-03-15 01:19:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=122866
7 years, 9 months ago (2013-03-15 02:28:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/12779010/19001
7 years, 9 months ago (2013-03-15 11:45:01 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-15 15:57:55 UTC) #8
Message was sent while issue was closed.
Change committed as 188401

Powered by Google App Engine
This is Rietveld 408576698