Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome_frame/test/mock_ie_event_sink_actions.h

Issue 12779010: Attempt to fix flake in FullTabDownloadTest.CF_DownloadFileFromPost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: motion to fix other test binaries Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/chrome_frame_test_utils.cc ('k') | chrome_frame/test/navigation_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/mock_ie_event_sink_actions.h
diff --git a/chrome_frame/test/mock_ie_event_sink_actions.h b/chrome_frame/test/mock_ie_event_sink_actions.h
index aee57725dc888a3ea9698abcd52842d26eb08ea6..a2f864a0af14eebedae330fbe0d60561ca27e7a7 100644
--- a/chrome_frame/test/mock_ie_event_sink_actions.h
+++ b/chrome_frame/test/mock_ie_event_sink_actions.h
@@ -17,7 +17,7 @@
#include "base/threading/platform_thread.h"
#include "base/time.h"
#include "chrome/common/chrome_switches.h"
-#include "chrome_frame/test/chrome_frame_ui_test_utils.h"
+#include "chrome_frame/test/chrome_frame_test_utils.h"
#include "chrome_frame/test/ie_event_sink.h"
#include "chrome_frame/test/mock_ie_event_sink_test.h"
#include "chrome_frame/test/simulate_input.h"
@@ -389,6 +389,7 @@ ACTION_P3(CloseWhenFileSaved, mock, file, timeout_ms) {
while (!file_util::PathExists(file)) {
if ((base::Time::Now() - start).InMilliseconds() > timeout_ms) {
ADD_FAILURE() << "File was not saved within timeout";
+ TakeSnapshotAndLog();
break;
}
base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(200));
@@ -402,6 +403,7 @@ ACTION_P2(WaitForFileSave, file, timeout_ms) {
base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(200));
if ((base::Time::Now() - start).InMilliseconds() > timeout_ms) {
ADD_FAILURE() << "File was not saved within timeout";
+ TakeSnapshotAndLog();
break;
}
}
« no previous file with comments | « chrome_frame/test/chrome_frame_test_utils.cc ('k') | chrome_frame/test/navigation_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698