Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7233)

Unified Diff: chrome_frame/test/chrome_frame_test_utils.h

Issue 12779010: Attempt to fix flake in FullTabDownloadTest.CF_DownloadFileFromPost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: motion to fix other test binaries Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome_frame/test/chrome_frame_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/chrome_frame_test_utils.h
diff --git a/chrome_frame/test/chrome_frame_test_utils.h b/chrome_frame/test/chrome_frame_test_utils.h
index bb3480dff3702f2d291b9a536268a490d5f822af..5d2e44c87d672b7785445e447ada59d40535c859 100644
--- a/chrome_frame/test/chrome_frame_test_utils.h
+++ b/chrome_frame/test/chrome_frame_test_utils.h
@@ -25,7 +25,6 @@
#include "base/time.h"
#include "base/win/registry.h"
#include "base/win/scoped_comptr.h"
-#include "chrome/test/base/ui_test_utils.h"
#include "chrome_frame/chrome_tab.h"
#include "chrome_frame/test/simulate_input.h"
#include "chrome_frame/test_utils.h"
@@ -58,6 +57,9 @@ base::ProcessHandle LaunchChrome(const std::wstring& url,
// not perform this initialization itself.
int CloseAllIEWindows();
+// Saves a screen snapshot to the desktop and logs its location.
+bool TakeSnapshotAndLog();
+
extern const wchar_t kIEImageName[];
extern const wchar_t kIEBrokerImageName[];
extern const char kChromeImageName[];
@@ -246,21 +248,7 @@ class TimedMsgLoop {
private:
static void SnapshotAndQuit() {
- base::FilePath snapshot;
- if (ui_test_utils::SaveScreenSnapshotToDesktop(&snapshot)) {
- testing::UnitTest* unit_test = testing::UnitTest::GetInstance();
- const testing::TestInfo* test_info = unit_test->current_test_info();
- std::string name;
- if (test_info != NULL) {
- name.append(test_info->test_case_name())
- .append(1, '.')
- .append(test_info->name());
- } else {
- name = "unknown test";
- }
- LOG(ERROR) << name << " timed out. Screen snapshot saved to "
- << snapshot.value();
- }
+ TakeSnapshotAndLog();
MessageLoop::current()->Quit();
}
« no previous file with comments | « no previous file | chrome_frame/test/chrome_frame_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698