Issue 12764018: Improve panel related tests to make them more reliable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12764018: Improve panel related tests to make them more reliable (Closed)

Created:
7 years, 9 months ago by jianli

Modified:
7 years, 3 months ago

Reviewers:

CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improve panel related tests to make them more reliable 1) Make all panel tests not to wait on calling MessageLoop::RunUtilIdle since it causes flakiness and does not work well on win-aura. 2) Remove delayed layout refresh logic in DockedPanelCollection because the previous reasons for such delayed refresh do not hold: a) It is not likely to create many docked panels in a very short time. b) At most 2 panels are affected when panel focus is changed. 3) Improve test DetachWithSqueeze to make it more reliable 4) Enable MinimizeTwoPanelsWithoutTabbedWindow since it passes now. BUG=103253 TEST=these are tests

Patch Set 1 : Patch #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -205 lines)			Patch
M	chrome/browser/ui/panels/base_panel_browser_test.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/panels/docked_panel_browsertest.cc	View	11 chunks	+3 lines, -27 lines	0 comments	Download
M	chrome/browser/ui/panels/docked_panel_collection.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/panels/docked_panel_collection.cc	View	2 chunks	+3 lines, -19 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browsertest.cc	View	5 chunks	+1 line, -20 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_collection.h	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_drag_browsertest.cc	View	5 chunks	+39 lines, -43 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_manager.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
D	chrome/browser/ui/panels/test_panel_collection_squeeze_observer.h	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	chrome/browser/ui/panels/test_panel_collection_squeeze_observer.cc	View	1 chunk	+0 lines, -39 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download