Improve panel related tests to make them more reliable

chrome/browser/ui/panels/docked_panel_collection.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/docked_panel_collection.h"
 
 #include <math.h>
 
 #include <algorithm>
 #include <vector>
@@ skipping 95 matching lines @@
   } else {
     DCHECK(update_bounds);
     int x = panel->GetBounds().x();
     Panels::iterator iter = panels_.begin();
     for (; iter != panels_.end(); ++iter)
       if (x > (*iter)->GetBounds().x())
         break;
     panels_.insert(iter, panel);
   }
 
-  if (update_bounds) {
-    if ((positioning_mask & DELAY_LAYOUT_REFRESH) != 0)
-      ScheduleLayoutRefresh();
-    else
-      RefreshLayout();
-  }
+  if (update_bounds)
+    RefreshLayout();
 }
 
 gfx::Point DockedPanelCollection::GetDefaultPositionForPanel(
     const gfx::Size& full_size) const {
   int x = 0;
   if (!panels_.empty() &&
       panels_.back()->GetBounds().x() < work_area_.x()) {
     // Panels go off screen. Make sure the default position will place
     // the panel in view.
     Panels::const_reverse_iterator iter = panels_.rbegin();
@@ skipping 627 matching lines @@
 }
 
 void DockedPanelCollection::UpdatePanelOnCollectionChange(Panel* panel) {
   panel->set_attention_mode(Panel::USE_PANEL_ATTENTION);
   panel->SetAlwaysOnTop(true);
   panel->EnableResizeByMouse(true);
   panel->UpdateMinimizeRestoreButtonVisibility();
   panel->SetWindowCornerStyle(panel::TOP_ROUNDED);
 }
 
-void DockedPanelCollection::ScheduleLayoutRefresh() {
-  refresh_action_factory_.InvalidateWeakPtrs();
-  MessageLoop::current()->PostDelayedTask(FROM_HERE,
-      base::Bind(&DockedPanelCollection::RefreshLayout,
-                 refresh_action_factory_.GetWeakPtr()),
-      base::TimeDelta::FromMilliseconds(PanelManager::AdjustTimeInterval(
-          kRefreshLayoutAfterActivePanelChangeDelayMs)));
-}
-
 void DockedPanelCollection::OnPanelActiveStateChanged(Panel* panel) {
-  // Refresh layout, but wait till active states settle.
-  // This lets us avoid refreshing too many times when one panel loses
-  // focus and another gains it.
-  ScheduleLayoutRefresh();
+  RefreshLayout();
 }
 
 bool DockedPanelCollection::HasPanel(Panel* panel) const {
   return find(panels_.begin(), panels_.end(), panel) != panels_.end();
 }