Issue 12745003: Switched to version generation with ver files.

Issue 12745003: Switched to version generation with ver files. (Closed)

Created:
7 years, 9 months ago by Vitaly Buka (NO REVIEWS)

Modified:
7 years, 9 months ago

Reviewers:
bungeman-chromium, gene

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switched to version generation with ver files. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187687

Patch Set 1 : #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -128 lines)			Patch
A	cloud_print/BRANDING	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	cloud_print/cloud_print.gyp	View	1 chunk	+48 lines, -0 lines	1 comment	Download
M	cloud_print/service/service.gyp	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	cloud_print/service/win/cloud_print_service.rc	View	1 chunk	+6 lines, -84 lines	0 comments	Download
A	cloud_print/service/win/cloud_print_service_exe.ver	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	cloud_print/virtual_driver/win/gcp_portmon64_dll.ver	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	cloud_print/virtual_driver/win/gcp_portmon_dll.ver	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	cloud_print/virtual_driver/win/install/virtual_driver_install.gyp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	cloud_print/virtual_driver/win/install/virtual_driver_setup_exe.ver	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	cloud_print/virtual_driver/win/virtual_driver.gypi	View	1 chunk	+2 lines, -1 line	0 comments	Download
D	cloud_print/virtual_driver/win/virtual_driver_common_resources.rc	View	1 chunk	+0 lines, -41 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/12745003/16

7 years, 9 months ago (2013-03-12 17:41:56 UTC) #4

bungeman-chromium

7 years, 9 months ago (2013-03-18 15:52:30 UTC) #6

Message was sent while issue was closed.

I've been working on a CMake gyp generator (see
https://codereview.chromium.org/12314014 ) which also happens to be working as a
linter. I noticed the following issue after this CL landed.

Essentially, on non-Windows systems, the 'cloud_print_service_exe_version.rc'
file isn't generated because 'cloud_print_service_exe.ver' was excluded as a
source. However, 'cloud_print_service_exe_version.rc' is still listed as a
source to a target.

I'm not very familiar with cloud_print, so I'm not sure the proper way around
this (currently I'm just commenting out 'service.gyp:65' on non-Windows to get
past this).

https://chromiumcodereview.appspot.com/12745003/diff/16/cloud_print/cloud_pri...
File cloud_print/cloud_print.gyp (right):

https://chromiumcodereview.appspot.com/12745003/diff/16/cloud_print/cloud_pri...
cloud_print/cloud_print.gyp:45: 'service/win/cloud_print_service_exe.ver',
This source would produce the version file, but it has 'win' in the name and is
being excluded on non-Windows platforms (via filename_rules.gypi included by
common.gypi).

https://chromiumcodereview.appspot.com/12745003/diff/16/cloud_print/service/s...
File cloud_print/service/service.gyp (right):

https://chromiumcodereview.appspot.com/12745003/diff/16/cloud_print/service/s...
cloud_print/service/service.gyp:65:
'<(SHARED_INTERMEDIATE_DIR)/cloud_print/cloud_print_service_exe_version.rc',
This target is excluded from the default build and isn't a dependency of outside
targets. However it is still a valid target (which won't link) on Linux. This
source file isn't being excluded because it doesn't have 'win' in the name. The
source file which would have caused it to be generated does have 'win' in the
name and was excluded.

Expand Messages | Collapse Messages