Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: cloud_print/cloud_print.gyp

Issue 12745003: Switched to version generation with ver files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cloud_print/cloud_print.gyp
diff --git a/cloud_print/cloud_print.gyp b/cloud_print/cloud_print.gyp
index a563cf54b9e084c98297874a94de5a5d575a6754..30d7e9ffd92a80d4b8a85c339a168a7179c2d9f1 100644
--- a/cloud_print/cloud_print.gyp
+++ b/cloud_print/cloud_print.gyp
@@ -2,8 +2,56 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
+ 'variables': {
+ 'chromium_code': 1,
+
+ 'variables': {
+ 'version_py_path': '../tools/build/version.py',
+ 'version_path': 'VERSION',
+ },
+ 'version_py_path': '<(version_py_path) -f',
+ 'version_path': '<(version_path)',
+ },
+ 'includes': [
+ '../chrome/version.gypi',
+ ],
'targets': [
{
+ 'target_name': 'cloud_print_version_resources',
+ 'type': 'none',
+ 'conditions': [
+ ['branding == "Chrome"', {
+ 'variables': {
+ 'branding_path': '<(DEPTH)/chrome/app/theme/google_chrome/BRANDING',
+ },
+ }, { # else branding!="Chrome"
+ 'variables': {
+ 'branding_path': '<(DEPTH)/chrome/app/theme/chromium/BRANDING',
+ },
+ }],
+ ],
+ 'variables': {
+ 'output_dir': 'cloud_print',
+ 'template_input_path': '../chrome/app/chrome_version.rc.version',
+ 'extra_variable_files_arguments': [ '-f', 'BRANDING' ],
+ 'extra_variable_files': [ 'BRANDING' ], # NOTE: matches that above
+ },
+ 'direct_dependent_settings': {
+ 'include_dirs': [
+ '<(SHARED_INTERMEDIATE_DIR)/<(output_dir)',
+ ],
+ },
+ 'sources': [
+ 'service/win/cloud_print_service_exe.ver',
bungeman-chromium 2013/03/18 15:52:30 This source would produce the version file, but it
+ 'virtual_driver/win/gcp_portmon64_dll.ver',
+ 'virtual_driver/win/gcp_portmon_dll.ver',
+ 'virtual_driver/win/install/virtual_driver_setup_exe.ver',
+ ],
+ 'includes': [
+ '../chrome/version_resource_rules.gypi',
+ ],
+ },
+ {
'target_name': 'cloud_print',
'type': 'none',
'dependencies': [

Powered by Google App Engine
This is Rietveld 408576698