Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: gpu/command_buffer/service/shader_translator_unittest.cc

Issue 1273693002: command_buffer: Use GLSL core version that matches the OpenGL version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/shader_translator_unittest.cc
diff --git a/gpu/command_buffer/service/shader_translator_unittest.cc b/gpu/command_buffer/service/shader_translator_unittest.cc
index 5f6173818f922b1fccf54e31bf338e68873c5ec4..c43ade6c20b3daaff816ebccef9b8fda8773e900 100644
--- a/gpu/command_buffer/service/shader_translator_unittest.cc
+++ b/gpu/command_buffer/service/shader_translator_unittest.cc
@@ -27,14 +27,12 @@ class ShaderTranslatorTest : public testing::Test {
vertex_translator_ = new ShaderTranslator();
fragment_translator_ = new ShaderTranslator();
- ASSERT_TRUE(vertex_translator_->Init(
- GL_VERTEX_SHADER, SH_GLES2_SPEC, &resources,
- ShaderTranslatorInterface::kGlsl,
- SH_EMULATE_BUILT_IN_FUNCTIONS));
- ASSERT_TRUE(fragment_translator_->Init(
- GL_FRAGMENT_SHADER, SH_GLES2_SPEC, &resources,
- ShaderTranslatorInterface::kGlsl,
- static_cast<ShCompileOptions>(0)));
+ ASSERT_TRUE(vertex_translator_->Init(GL_VERTEX_SHADER, SH_GLES2_SPEC,
+ &resources, SH_GLSL_150_CORE_OUTPUT,
Ken Russell (switch to Gerrit) 2015/08/05 18:29:38 I'm not sure the 150_CORE_OUTPUT will be the commo
Kimmo Kinnunen 2015/08/10 08:36:34 Done.
+ SH_EMULATE_BUILT_IN_FUNCTIONS));
+ ASSERT_TRUE(fragment_translator_->Init(GL_FRAGMENT_SHADER, SH_GLES2_SPEC,
+ &resources, SH_GLSL_150_CORE_OUTPUT,
+ static_cast<ShCompileOptions>(0)));
}
void TearDown() override {
vertex_translator_ = NULL;
@@ -290,19 +288,16 @@ TEST_F(ShaderTranslatorTest, OptionsString) {
ShBuiltInResources resources;
ShInitBuiltInResources(&resources);
- ASSERT_TRUE(translator_1->Init(
- GL_VERTEX_SHADER, SH_GLES2_SPEC, &resources,
- ShaderTranslatorInterface::kGlsl,
- SH_EMULATE_BUILT_IN_FUNCTIONS));
- ASSERT_TRUE(translator_2->Init(
- GL_FRAGMENT_SHADER, SH_GLES2_SPEC, &resources,
- ShaderTranslatorInterface::kGlsl,
- static_cast<ShCompileOptions>(0)));
+ ASSERT_TRUE(translator_1->Init(GL_VERTEX_SHADER, SH_GLES2_SPEC, &resources,
+ SH_GLSL_150_CORE_OUTPUT,
+ SH_EMULATE_BUILT_IN_FUNCTIONS));
+ ASSERT_TRUE(translator_2->Init(GL_FRAGMENT_SHADER, SH_GLES2_SPEC, &resources,
+ SH_GLSL_150_CORE_OUTPUT,
+ static_cast<ShCompileOptions>(0)));
resources.EXT_draw_buffers = 1;
- ASSERT_TRUE(translator_3->Init(
- GL_VERTEX_SHADER, SH_GLES2_SPEC, &resources,
- ShaderTranslatorInterface::kGlsl,
- SH_EMULATE_BUILT_IN_FUNCTIONS));
+ ASSERT_TRUE(translator_3->Init(GL_VERTEX_SHADER, SH_GLES2_SPEC, &resources,
+ SH_GLSL_150_CORE_OUTPUT,
+ SH_EMULATE_BUILT_IN_FUNCTIONS));
std::string options_1(
translator_1->GetStringForOptionsThatWouldAffectCompilation());

Powered by Google App Engine
This is Rietveld 408576698