Inconsistent use of [x] close panel icon. Code changes.

Inconsistent use of [x] close panel icon. Code changes.
The close button in download pane should be the tab close button asset : tab_close_*.png (this was originally reported as part of BUG=173251
).

By the same logic the same smaller bitmap with red hover background should be used for all infobars
such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all
platforms (Mac was missed with the previous implementation).

The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested).

Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE.
IDR_TAB_CLOSE was renamed IDR_CLOSE_1.
IDR_CLOSE_BAR was renamed IDR_CLOSE_2.
png files were also renamed (this is handled by two separate committs to work around restriction on binary committs by newbies).
See https://codereview.chromium.org/12703022/ for added resources.

BUG=217094
TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button.

TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it).

TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way.

TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094
). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190844

[varkha, 2013-03-26 22:14:08]

This was reviewed before (except for chrome/browser/search/local_ntp_source.cc
which is a new file that appeared today. I haven't changed the resource used in
that new page - just renamed the ID / png used. Can you please land it for me -
the try bot seems to be fine now.
Previously known as https://codereview.chromium.org/12634025/.

[varkha, 2013-03-26 22:23:13]

sky@, Can you please review this. It is the same change you looked at before -
see previous comment.

[sky, 2013-03-26 22:51:40]

Rubber stamp LGTM - in the future make patchset 1 the original patchset so that
it's easy to diff.

[commit-bot: I haz the power, 2013-03-26 23:06:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/12703039/9021

[commit-bot: I haz the power, 2013-03-27 07:08:02]

Change committed as 190844