chrome/browser/ui/views/notifications/balloon_view_views.cc - Issue 12703039: Inconsistent use of [x] close panel icon. Code changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/notifications/balloon_view_views.cc

Issue 12703039: Inconsistent use of [x] close panel icon. Code changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added recently added local NTP file. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/infobars/infobar_view.cc ('k') | chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/notifications/balloon_view_views.cc

diff --git a/chrome/browser/ui/views/notifications/balloon_view_views.cc b/chrome/browser/ui/views/notifications/balloon_view_views.cc

index 7ff2ada54f4e076e20d0065374138914c51d7c8f..967922ecd1228a7cb8c1f1f717da768b572e2f43 100644

--- a/chrome/browser/ui/views/notifications/balloon_view_views.cc

+++ b/chrome/browser/ui/views/notifications/balloon_view_views.cc

@@ -357,15 +357,15 @@ void BalloonViewImpl::Show(Balloon* balloon) {

frame_container_->SetAlwaysOnTop(true);

close_button_->SetImage(views::CustomButton::STATE_NORMAL,

- rb.GetImageSkiaNamed(IDR_TAB_CLOSE));

+ rb.GetImageSkiaNamed(IDR_CLOSE_1));

close_button_->SetImage(views::CustomButton::STATE_HOVERED,

- rb.GetImageSkiaNamed(IDR_TAB_CLOSE_H));

+ rb.GetImageSkiaNamed(IDR_CLOSE_1_H));

close_button_->SetImage(views::CustomButton::STATE_PRESSED,

- rb.GetImageSkiaNamed(IDR_TAB_CLOSE_P));

+ rb.GetImageSkiaNamed(IDR_CLOSE_1_P));

close_button_->SetBoundsRect(GetCloseButtonBounds());

close_button_->SetBackground(SK_ColorBLACK,

- rb.GetImageSkiaNamed(IDR_TAB_CLOSE),

- rb.GetImageSkiaNamed(IDR_TAB_CLOSE_MASK));

+ rb.GetImageSkiaNamed(IDR_CLOSE_1),

+ rb.GetImageSkiaNamed(IDR_CLOSE_1_MASK));

options_menu_button_->SetIcon(*rb.GetImageSkiaNamed(IDR_BALLOON_WRENCH));

options_menu_button_->SetHoverIcon(

« no previous file with comments | « chrome/browser/ui/views/infobars/infobar_view.cc ('k') | chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc » ('j') | no next file with comments »