Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: chrome/browser/search/local_ntp_source.cc

Issue 12703039: Inconsistent use of [x] close panel icon. Code changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added recently added local NTP file. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/search/local_ntp_source.h" 5 #include "chrome/browser/search/local_ntp_source.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/memory/ref_counted_memory.h" 8 #include "base/memory/ref_counted_memory.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "chrome/common/url_constants.h" 10 #include "chrome/common/url_constants.h"
11 #include "content/public/common/content_client.h" 11 #include "content/public/common/content_client.h"
12 #include "googleurl/src/gurl.h" 12 #include "googleurl/src/gurl.h"
13 #include "grit/browser_resources.h" 13 #include "grit/browser_resources.h"
14 #include "grit/ui_resources.h" 14 #include "grit/ui_resources.h"
15 #include "net/url_request/url_request.h" 15 #include "net/url_request/url_request.h"
16 16
17 namespace { 17 namespace {
18 18
19 const char kHtmlFilename[] = "local-ntp.html"; 19 const char kHtmlFilename[] = "local-ntp.html";
20 const char kJSFilename[] = "local-ntp.js"; 20 const char kJSFilename[] = "local-ntp.js";
21 const char kCssFilename[] = "local-ntp.css"; 21 const char kCssFilename[] = "local-ntp.css";
22 const char kCloseBarFilename[] = "images/close_bar.png"; 22 const char kCloseBarFilename[] = "images/close_2.png";
23 const char kCloseBarHoverFilename[] = "images/close_bar_hover.png"; 23 const char kCloseBarHoverFilename[] = "images/close_2_hover.png";
24 const char kCloseBarActiveFilename[] = "images/close_bar_active.png"; 24 const char kCloseBarActiveFilename[] = "images/close_2_active.png";
25 25
26 } // namespace 26 } // namespace
27 27
28 LocalNtpSource::LocalNtpSource() { 28 LocalNtpSource::LocalNtpSource() {
29 } 29 }
30 30
31 LocalNtpSource::~LocalNtpSource() { 31 LocalNtpSource::~LocalNtpSource() {
32 } 32 }
33 33
34 std::string LocalNtpSource::GetSource() { 34 std::string LocalNtpSource::GetSource() {
35 return chrome::kChromeSearchLocalNtpHost; 35 return chrome::kChromeSearchLocalNtpHost;
36 } 36 }
37 37
38 void LocalNtpSource::StartDataRequest( 38 void LocalNtpSource::StartDataRequest(
39 const std::string& path, 39 const std::string& path,
40 bool is_incognito, 40 bool is_incognito,
41 const content::URLDataSource::GotDataCallback& callback) { 41 const content::URLDataSource::GotDataCallback& callback) {
42 int identifier = -1; 42 int identifier = -1;
43 if (path == kHtmlFilename) { 43 if (path == kHtmlFilename) {
44 identifier = IDR_LOCAL_NTP_HTML; 44 identifier = IDR_LOCAL_NTP_HTML;
45 } else if (path == kJSFilename) { 45 } else if (path == kJSFilename) {
46 identifier = IDR_LOCAL_NTP_JS; 46 identifier = IDR_LOCAL_NTP_JS;
47 } else if (path == kCssFilename) { 47 } else if (path == kCssFilename) {
48 identifier = IDR_LOCAL_NTP_CSS; 48 identifier = IDR_LOCAL_NTP_CSS;
49 } else if (path == kCloseBarFilename) { 49 } else if (path == kCloseBarFilename) {
50 identifier = IDR_CLOSE_BAR; 50 identifier = IDR_CLOSE_2;
51 } else if (path == kCloseBarHoverFilename) { 51 } else if (path == kCloseBarHoverFilename) {
52 identifier = IDR_CLOSE_BAR_H; 52 identifier = IDR_CLOSE_2_H;
53 } else if (path == kCloseBarActiveFilename) { 53 } else if (path == kCloseBarActiveFilename) {
54 identifier = IDR_CLOSE_BAR_P; 54 identifier = IDR_CLOSE_2_P;
55 } else { 55 } else {
56 callback.Run(NULL); 56 callback.Run(NULL);
57 return; 57 return;
58 } 58 }
59 59
60 scoped_refptr<base::RefCountedStaticMemory> response( 60 scoped_refptr<base::RefCountedStaticMemory> response(
61 content::GetContentClient()->GetDataResourceBytes(identifier)); 61 content::GetContentClient()->GetDataResourceBytes(identifier));
62 callback.Run(response); 62 callback.Run(response);
63 } 63 }
64 64
(...skipping 19 matching lines...) Expand all
84 if (request->url().SchemeIs(chrome::kChromeSearchScheme)) { 84 if (request->url().SchemeIs(chrome::kChromeSearchScheme)) {
85 DCHECK(StartsWithASCII(request->url().path(), "/", true)); 85 DCHECK(StartsWithASCII(request->url().path(), "/", true));
86 std::string filename = request->url().path().substr(1); 86 std::string filename = request->url().path().substr(1);
87 return filename == kHtmlFilename || filename == kJSFilename || 87 return filename == kHtmlFilename || filename == kJSFilename ||
88 filename == kCssFilename || filename == kCloseBarFilename || 88 filename == kCssFilename || filename == kCloseBarFilename ||
89 filename == kCloseBarHoverFilename || 89 filename == kCloseBarHoverFilename ||
90 filename == kCloseBarActiveFilename; 90 filename == kCloseBarActiveFilename;
91 } 91 }
92 return false; 92 return false;
93 } 93 }
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/options_page.css ('k') | chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698