Remove chrome/ code to handle App Notifications

Remove chrome/ code to handle App Notifications

The sync/ code will be removed in a follow up patch.

BUG=136297
TBR=thakis

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187201

[dcheng, 2013-03-08 23:00:42]

Overall, the patch is a fairly straightforward deletion of code. I've nuked the
following code for handling app notifications:
- The NTP page and associated theme resources/strings.
- Command line flags.
- Most of the sync glue. I left the sync preference for the moment, since it has
a dependency on code in sync/ which is not being removed in this patch.
- All of the extensions code and associated glue (renderer bindings, etc)

From my conversation with Tim, the current sync changes should be safe; we
simply don't register a handler for APP_NOTIFICATIONS, which is something that
sync needs to handle gracefully anyway.

I'm updating the ProfileSyncService tests now to account for the fact that we
have one fewer handler than before. I'm planning on TBRing most of the approvals
after manually verifying I didn't horribly break the new tab page.

[not at google - send to devlin, 2013-03-08 23:44:10]

hooray lgtm

https://codereview.chromium.org/12680004/diff/9001/chrome/browser/extensions/...
File chrome/browser/extensions/extension_service.cc (left):

https://codereview.chromium.org/12680004/diff/9001/chrome/browser/extensions/...
chrome/browser/extensions/extension_service.cc:1662:
UMA_HISTOGRAM_COUNTS("Apps.SetAppNotificationsEnabled", 1);
need to remember to remove this UMA.

[Nicolas Zea, 2013-03-09 00:52:36]

On 2013/03/08 23:44:10, kalman wrote:
> hooray lgtm
> 
>
https://codereview.chromium.org/12680004/diff/9001/chrome/browser/extensions/...
> File chrome/browser/extensions/extension_service.cc (left):
> 
>
https://codereview.chromium.org/12680004/diff/9001/chrome/browser/extensions/...
> chrome/browser/extensions/extension_service.cc:1662:
> UMA_HISTOGRAM_COUNTS("Apps.SetAppNotificationsEnabled", 1);
> need to remember to remove this UMA.

sync/ LGTM

[commit-bot: I haz the power, 2013-03-09 04:47:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/12680004/15001

[commit-bot: I haz the power, 2013-03-09 04:48:34]

Presubmit check for 12680004-15001 failed and returned exit status 1.

INFO:root:Found 47 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/app/theme/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/extensions/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/resources/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/sync/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/browser/ui/webui/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/common/extensions/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/test/ext_auto/auto_provider/manifest.json
    chrome/common/extensions/extension_messages.h
    chrome/browser/resources/ntp4/apps_page.css
    chrome/browser/resources/webstore_app/manifest.json
    chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
    chrome/chrome_browser.gypi
    chrome/browser/signin/signin_internals_util.cc
    chrome/browser/signin/signin_internals_util.h
    chrome/browser/ui/webui/ntp/app_launcher_handler.cc
    chrome/browser/resources/ntp4/apps_page.js
    chrome/app/theme/theme_resources.grd
    chrome/browser/ui/webui/ntp/app_launcher_handler.h
    chrome/browser/automation/automation_provider_observers.cc
    chrome/common/chrome_notification_types.h
    chrome/chrome_browser_extensions.gypi

Presubmit checks took 9.7s to calculate.

[commit-bot: I haz the power, 2013-03-09 04:54:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/12680004/15001

[commit-bot: I haz the power, 2013-03-09 14:58:20]

Failed to apply patch for
chrome/renderer/resources/extensions/app_custom_bindings.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/renderer/resources/extensions/app_custom_bindings.js
  Hunk #1 succeeded at 28 (offset 2 lines).
  Hunk #2 FAILED at 34.
  Hunk #3 FAILED at 63.
  2 out of 3 hunks FAILED -- saving rejects to file
chrome/renderer/resources/extensions/app_custom_bindings.js.rej

Patch:       chrome/renderer/resources/extensions/app_custom_bindings.js
Index: chrome/renderer/resources/extensions/app_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/app_custom_bindings.js
b/chrome/renderer/resources/extensions/app_custom_bindings.js
index
1a8bbcc7d6dab3ecaf05cee5574a61aed13e9ca4..4d28b3db7e2fca3c08b50168ed3c227fc4a6e18c
100644
--- a/chrome/renderer/resources/extensions/app_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/app_custom_bindings.js
@@ -26,13 +26,6 @@ app.__defineGetter__('isInstalled',
appNatives.GetIsInstalled);
 // Called by app_bindings.cc.
 // This becomes chromeHidden.app
 var chromeHiddenApp = {
-  onGetAppNotifyChannelResponse: function(channelId, error, callbackId) {
-    if (callbackId) {
-      callbacks[callbackId](channelId, error);
-      delete callbacks[callbackId];
-    }
-  },
-
   onInstallStateResponse: function(state, callbackId) {
     if (callbackId) {
       callbacks[callbackId](state);
@@ -41,26 +34,10 @@ var chromeHiddenApp = {
   }
 };
 
-// appNotification stuff.
-//
 // TODO(kalman): move this stuff to its own custom bindings.
-// It will be bit tricky since I'll need to look into why there are
-// permissions defined for app notifications, yet this always sets it up?
 var callbacks = {};
 var nextCallbackId = 1;
 
-// This becomes chrome.appNotifications.
-var appNotifications = {
-  getChannel: function getChannel(clientId, callback) {
-    var callbackId = 0;
-    if (callback) {
-      callbackId = nextCallbackId++;
-      callbacks[callbackId] = callback;
-    }
-    appNatives.GetAppNotifyChannel(clientId, callbackId);
-  }
-};
-
 app.installState = function getInstallState(callback) {
   var callbackId = nextCallbackId++;
   callbacks[callbackId] = callback;
@@ -70,5 +47,4 @@ app.installState = function getInstallState(callback) {
 // These must match the names in InstallAppBindings() in
 // chrome/renderer/extensions/dispatcher.cc.
 exports.chromeApp = app;
-exports.chromeAppNotifications = appNotifications;
 exports.chromeHiddenApp = chromeHiddenApp;

[commit-bot: I haz the power, 2013-03-10 05:45:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/12680004/30001

[commit-bot: I haz the power, 2013-03-10 08:19:06]

Change committed as 187201