Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3983)

Unified Diff: chrome/browser/extensions/app_notification_manager_unittest.cc

Issue 12680004: Remove chrome/ code to handle App Notifications (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge conflicts. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/app_notification_manager_unittest.cc
diff --git a/chrome/browser/extensions/app_notification_manager_unittest.cc b/chrome/browser/extensions/app_notification_manager_unittest.cc
deleted file mode 100644
index 0579aa81a8d16e50443bc336212bfaf719fb090e..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/app_notification_manager_unittest.cc
+++ /dev/null
@@ -1,132 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/bind.h"
-#include "base/message_loop.h"
-#include "chrome/browser/extensions/app_notification_manager.h"
-#include "chrome/browser/extensions/app_notification_test_util.h"
-#include "chrome/common/chrome_notification_types.h"
-#include "chrome/common/extensions/extension.h"
-#include "chrome/common/extensions/extension_manifest_constants.h"
-#include "chrome/common/extensions/extension_test_util.h"
-#include "chrome/test/base/testing_profile.h"
-#include "content/public/browser/notification_details.h"
-#include "content/public/browser/notification_service.h"
-#include "content/public/browser/notification_source.h"
-#include "content/public/test/test_browser_thread.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-using content::BrowserThread;
-
-namespace util = app_notification_test_util;
-
-namespace extensions {
-
-class AppNotificationManagerTest : public testing::Test {
- public:
- AppNotificationManagerTest()
- : ui_thread_(BrowserThread::UI, &ui_loop_),
- file_thread_(BrowserThread::FILE) {}
-
- virtual ~AppNotificationManagerTest() {}
-
- virtual void SetUp() OVERRIDE {
- ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::UI));
- file_thread_.Start();
- ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
- profile_.reset(new TestingProfile(temp_dir_.path()));
- InitializeManager();
- }
-
- virtual void TearDown() OVERRIDE {
- mgr_ = NULL;
- // Let the manager's shutdown of storage on the file thread complete.
- WaitForFileThread();
- }
-
- protected:
- void InitializeManager() {
- if (mgr_.get())
- WaitForFileThread();
- mgr_ = new AppNotificationManager(profile_.get());
- mgr_->Init();
- WaitForFileThread();
- }
-
- static void PostQuitToUIThread() {
- BrowserThread::PostTask(BrowserThread::UI,
- FROM_HERE,
- MessageLoop::QuitClosure());
- }
-
- static void WaitForFileThread() {
- BrowserThread::PostTask(BrowserThread::FILE,
- FROM_HERE,
- base::Bind(&PostQuitToUIThread));
- MessageLoop::current()->Run();
- }
-
- MessageLoop ui_loop_;
- content::TestBrowserThread ui_thread_;
- content::TestBrowserThread file_thread_;
- base::ScopedTempDir temp_dir_;
- scoped_ptr<TestingProfile> profile_;
- scoped_refptr<AppNotificationManager> mgr_;
-};
-
-TEST_F(AppNotificationManagerTest, Simple) {
- std::string id = extension_test_util::MakeId("whatever");
- AppNotificationList list;
- util::AddNotifications(&list, id, 2, "foo");
- EXPECT_TRUE(util::AddCopiesFromList(mgr_.get(), list));
-
- // Cause |mgr_| to be recreated, re-reading from its storage.
- InitializeManager();
-
- const AppNotification* tmp = mgr_->GetLast(id);
- ASSERT_TRUE(tmp);
- EXPECT_EQ(list[1]->guid(), tmp->guid());
- EXPECT_EQ(list[1]->extension_id(), tmp->extension_id());
- EXPECT_EQ(list[1]->is_local(), tmp->is_local());
- EXPECT_TRUE(list[1]->Equals(*tmp));
- const AppNotificationList* tmp_list = mgr_->GetAll(id);
- ASSERT_TRUE(tmp_list != NULL);
- util::ExpectListsEqual(list, *tmp_list);
- mgr_->ClearAll(id);
- EXPECT_EQ(NULL, mgr_->GetLast(id));
- EXPECT_EQ(NULL, mgr_->GetAll(id));
-}
-
-// Test that AppNotificationManager correctly listens to EXTENSION_UNINSTALLED
-// notifications and removes associated data when that happens.
-TEST_F(AppNotificationManagerTest, ExtensionUninstall) {
- // Add some items from two test extension ids.
- scoped_refptr<Extension> extension1 =
- extension_test_util::CreateExtensionWithID("id1");
- scoped_refptr<Extension> extension2 =
- extension_test_util::CreateExtensionWithID("id2");
- std::string id1 = extension1->id();
- std::string id2 = extension2->id();
- AppNotificationList list1;
- AppNotificationList list2;
- util::AddNotifications(&list1, id1, 5, "foo1");
- util::AddNotifications(&list2, id2, 3, "foo2");
- util::AddCopiesFromList(mgr_.get(), list1);
- util::AddCopiesFromList(mgr_.get(), list2);
- util::ExpectListsEqual(list1, *mgr_->GetAll(id1));
- util::ExpectListsEqual(list2, *mgr_->GetAll(id2));
-
- // Send the uninstall notification for extension id1.
- content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_EXTENSION_UNINSTALLED,
- content::Source<Profile>(profile_.get()),
- content::Details<const Extension>(extension1.get()));
-
- // The id1 items should be gone but the id2 items should still be there.
- EXPECT_EQ(NULL, mgr_->GetLast(id1));
- EXPECT_EQ(NULL, mgr_->GetAll(id1));
- util::ExpectListsEqual(list2, *mgr_->GetAll(id2));
-}
-
-} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698