Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Side by Side Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 12680004: Remove chrome/ code to handle App Notifications (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge conflicts. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/json/json_file_value_serializer.h" 6 #include "base/json/json_file_value_serializer.h"
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "chrome/common/chrome_paths.h" 10 #include "chrome/common/chrome_paths.h"
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
655 TEST_F(PermissionsTest, PermissionMessages) { 655 TEST_F(PermissionsTest, PermissionMessages) {
656 // Ensure that all permissions that needs to show install UI actually have 656 // Ensure that all permissions that needs to show install UI actually have
657 // strings associated with them. 657 // strings associated with them.
658 APIPermissionSet skip; 658 APIPermissionSet skip;
659 659
660 // These are considered "nuisance" or "trivial" permissions that don't need 660 // These are considered "nuisance" or "trivial" permissions that don't need
661 // a prompt. 661 // a prompt.
662 skip.insert(APIPermission::kActiveTab); 662 skip.insert(APIPermission::kActiveTab);
663 skip.insert(APIPermission::kAlarms); 663 skip.insert(APIPermission::kAlarms);
664 skip.insert(APIPermission::kAppCurrentWindowInternal); 664 skip.insert(APIPermission::kAppCurrentWindowInternal);
665 skip.insert(APIPermission::kAppNotifications);
666 skip.insert(APIPermission::kAppRuntime); 665 skip.insert(APIPermission::kAppRuntime);
667 skip.insert(APIPermission::kAppWindow); 666 skip.insert(APIPermission::kAppWindow);
668 skip.insert(APIPermission::kBrowsingData); 667 skip.insert(APIPermission::kBrowsingData);
669 skip.insert(APIPermission::kContextMenus); 668 skip.insert(APIPermission::kContextMenus);
670 skip.insert(APIPermission::kFontSettings); 669 skip.insert(APIPermission::kFontSettings);
671 skip.insert(APIPermission::kFullscreen); 670 skip.insert(APIPermission::kFullscreen);
672 skip.insert(APIPermission::kIdle); 671 skip.insert(APIPermission::kIdle);
673 skip.insert(APIPermission::kNotification); 672 skip.insert(APIPermission::kNotification);
674 skip.insert(APIPermission::kPointerLock); 673 skip.insert(APIPermission::kPointerLock);
675 skip.insert(APIPermission::kPushMessaging); 674 skip.insert(APIPermission::kPushMessaging);
(...skipping 694 matching lines...) Expand 10 before | Expand all | Expand 10 after
1370 apis.insert(APIPermission::kWebRequest); 1369 apis.insert(APIPermission::kWebRequest);
1371 apis.insert(APIPermission::kFileBrowserHandler); 1370 apis.insert(APIPermission::kFileBrowserHandler);
1372 EXPECT_EQ(2U, apis.size()); 1371 EXPECT_EQ(2U, apis.size());
1373 1372
1374 scoped_refptr<PermissionSet> perm_set; 1373 scoped_refptr<PermissionSet> perm_set;
1375 perm_set = new PermissionSet(apis, empty_extent, empty_extent); 1374 perm_set = new PermissionSet(apis, empty_extent, empty_extent);
1376 EXPECT_EQ(4U, perm_set->apis().size()); 1375 EXPECT_EQ(4U, perm_set->apis().size());
1377 } 1376 }
1378 1377
1379 } // namespace extensions 1378 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/permissions/api_permission.cc ('k') | chrome/renderer/extensions/app_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698