Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1263573004: Move NTP related classes to ntp package. (Closed)

Created:
5 years, 4 months ago by aurimas (slooooooooow)
Modified:
5 years, 4 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move NTP related classes to ntp package. This CL moves the following classes to org.chromium.chrome.browser.ntp: - ForeignSessionHelper - LogoBridge - NewTabPagePrefs - RecentlyClosedBridge BUG=None Committed: https://crrev.com/ac6511db52baccb2c358852e5288e43589377a0b Cr-Commit-Position: refs/heads/master@{#341039}

Patch Set 1 #

Total comments: 8

Patch Set 2 : newt's nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -941 lines) Patch
D chrome/android/java/src/org/chromium/chrome/browser/ForeignSessionHelper.java View 1 chunk +0 lines, -221 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/LogoBridge.java View 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java View 1 chunk +0 lines, -144 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java View 1 chunk +0 lines, -124 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/DocumentRecentTabsManager.java View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/ForeignSessionHelper.java View 1 11 chunks +23 lines, -23 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoBridge.java View 1 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/LogoView.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 2 chunks +2 lines, -3 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPagePrefs.java View 11 chunks +15 lines, -15 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsGroupView.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java View 1 chunk +5 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentlyClosedBridge.java View 1 8 chunks +10 lines, -10 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/document/DocumentModeRecentlyClosedTest.java View 1 1 chunk +0 lines, -267 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/ntp/DocumentModeRecentlyClosedTest.java View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
aurimas (slooooooooow)
PTAL
5 years, 4 months ago (2015-07-29 21:15:44 UTC) #2
newt (away)
I'm OK with making the various JNI classes package-private, but if you're going to do ...
5 years, 4 months ago (2015-07-29 22:35:32 UTC) #3
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/1263573004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/ForeignSessionHelper.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/ForeignSessionHelper.java (right): https://chromiumcodereview.appspot.com/1263573004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/ForeignSessionHelper.java#newcode26 chrome/android/java/src/org/chromium/chrome/browser/ntp/ForeignSessionHelper.java:26: public interface ForeignSessionCallback { On 2015/07/29 at 22:35:32, newt ...
5 years, 4 months ago (2015-07-29 23:03:41 UTC) #4
newt (away)
lgtm
5 years, 4 months ago (2015-07-29 23:21:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263573004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263573004/20001
5 years, 4 months ago (2015-07-29 23:24:15 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 02:12:40 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 02:13:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac6511db52baccb2c358852e5288e43589377a0b
Cr-Commit-Position: refs/heads/master@{#341039}

Powered by Google App Engine
This is Rietveld 408576698