Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentlyClosedBridge.java

Issue 1263573004: Move NTP related classes to ntp package. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: newt's nits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentlyClosedBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentlyClosedBridge.java
similarity index 88%
rename from chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java
rename to chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentlyClosedBridge.java
index 9a7ac4abfc4dfb019ae60cfde51596a458ea824c..3b060354305cb82578456f202bb918170339d885 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentlyClosedBridge.java
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-package org.chromium.chrome.browser;
+package org.chromium.chrome.browser.ntp;
import org.chromium.base.CalledByNative;
import org.chromium.chrome.browser.profiles.Profile;
@@ -14,13 +14,13 @@ import java.util.List;
/**
* This class allows Java code to get and clear the list of recently closed tabs.
*/
-public class RecentlyClosedBridge {
+class RecentlyClosedBridge {
private long mNativeRecentlyClosedTabsBridge;
/**
* Callback interface for getting notified when the list of recently closed tabs is updated.
*/
- public interface RecentlyClosedCallback {
+ interface RecentlyClosedCallback {
/**
* This method will be called every time the list of recently closed tabs is updated.
*
@@ -34,7 +34,7 @@ public class RecentlyClosedBridge {
/**
* Represents a recently closed tab.
*/
- public static class RecentlyClosedTab {
+ static class RecentlyClosedTab {
public final int id;
public final String title;
public final String url;
@@ -57,14 +57,14 @@ public class RecentlyClosedBridge {
* Initializes this class with the given profile.
* @param profile The Profile whose recently closed tabs will be queried.
*/
- public RecentlyClosedBridge(Profile profile) {
+ RecentlyClosedBridge(Profile profile) {
mNativeRecentlyClosedTabsBridge = nativeInit(profile);
}
/**
* Cleans up the C++ side of this class. This instance must not be used after calling destroy().
*/
- public void destroy() {
+ void destroy() {
assert mNativeRecentlyClosedTabsBridge != 0;
nativeDestroy(mNativeRecentlyClosedTabsBridge);
mNativeRecentlyClosedTabsBridge = 0;
@@ -74,7 +74,7 @@ public class RecentlyClosedBridge {
* Sets the callback to be called whenever the list of recently closed tabs changes.
* @param callback The RecentlyClosedCallback to be notified, or null.
*/
- public void setRecentlyClosedCallback(RecentlyClosedCallback callback) {
+ void setRecentlyClosedCallback(RecentlyClosedCallback callback) {
nativeSetRecentlyClosedCallback(mNativeRecentlyClosedTabsBridge, callback);
}
@@ -82,7 +82,7 @@ public class RecentlyClosedBridge {
* @param maxTabCount The maximum number of recently closed tabs to return.
* @return The list of recently closed tabs, with up to maxTabCount elements.
*/
- public List<RecentlyClosedTab> getRecentlyClosedTabs(int maxTabCount) {
+ List<RecentlyClosedTab> getRecentlyClosedTabs(int maxTabCount) {
List<RecentlyClosedTab> tabs = new ArrayList<RecentlyClosedTab>();
boolean received = nativeGetRecentlyClosedTabs(mNativeRecentlyClosedTabsBridge, tabs,
maxTabCount);
@@ -99,7 +99,7 @@ public class RecentlyClosedBridge {
* the current tab or a new tab.
* @return Whether the tab was successfully opened.
*/
- public boolean openRecentlyClosedTab(Tab tab, RecentlyClosedTab recentTab,
+ boolean openRecentlyClosedTab(Tab tab, RecentlyClosedTab recentTab,
int windowOpenDisposition) {
return nativeOpenRecentlyClosedTab(mNativeRecentlyClosedTabsBridge, tab, recentTab.id,
windowOpenDisposition);
@@ -108,7 +108,7 @@ public class RecentlyClosedBridge {
/**
* Clears all recently closed tabs.
*/
- public void clearRecentlyClosedTabs() {
+ void clearRecentlyClosedTabs() {
nativeClearRecentlyClosedTabs(mNativeRecentlyClosedTabsBridge);
}

Powered by Google App Engine
This is Rietveld 408576698